Differential D8136

Fix mypy error
ClosedPublic
Actions

Authored by vlorentz on Jul 19 2022, 2:55 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDVAUceb26750ad9d: Fix mypy error

Summary

This is not a runtime issue, because when the supplied mode is DentryPerms.symlink,
the target is only used passed to os.symlink, which does allow str too.

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 19 2022, 2:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 19 2022, 2:55 PM

Build is green

Patch application report for D8136 (id=29379)

Rebasing onto c07d934aef...

Current branch diff-target is up to date.

Changes applied before test

commit ceb26750ad9ddaeb8d725f18051f6f34038f3672
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 19 14:55:07 2022 +0200

    Fix mypy error
    
    This is not a runtime issue, because when the supplied mode is DentryPerms.symlink,
    the target is only used passed to os.symlink, which does allow str too.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/242/ for more details.

Harbormaster completed remote builds in B30453: Diff 29379.Jul 19 2022, 2:58 PM

vlorentz requested review of this revision.Jul 19 2022, 2:58 PM

ardumont accepted this revision.Jul 19 2022, 5:08 PM

This revision is now accepted and ready to land.Jul 19 2022, 5:08 PM

Closed by commit rDVAUceb26750ad9d: Fix mypy error (authored by vlorentz). · Explain WhyJul 19 2022, 5:10 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDVAUceb26750ad9d: Fix mypy error.