Page MenuHomeSoftware Heritage

Build web assets in swh-web container.
AbandonedPublic

Authored by vlorentz on Jan 11 2019, 12:08 PM.

Details

Reviewers
None
Group Reviewers
Reviewers

Diff Detail

Repository
rCDFD Dockerfiles for developers
Branch
web-assets
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3426
Build 4412: arc lint + arc unit

Event Timeline

anlambert added inline comments.
dockerfiles/swh-web/Dockerfile
7

package name is nodejs here, not npm

Static assets are packed in the wheel archive available on PyPI so they do not need to be built again.

If you are mapping your local source tree of swh-web through the docker-compose.override.yml file,
it's up to you to build the static assets locally.

To summarize, that diff is not needed and can be abandoned.