Differential D8051

Arch, use **kwargs on task initialisation instead of named args.
ClosedPublic
Actions

Authored by franckbret on Jun 29 2022, 3:56 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDBASE01547b8edff5: Arch, use **kwargs on task initialisation instead of named args.

Summary

This fix an issue discovered while testing loader on docker environment,
error was (load_arch() got an unexpected keyword argument
'lister_name')

Related T4233

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30129
Build 47087: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47086: arc lint + arc unit

Event Timeline

franckbret created this revision.Jun 29 2022, 3:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 29 2022, 3:56 PM

Build is green

Patch application report for D8051 (id=29043)

Rebasing onto 50bde53da5...

Current branch diff-target is up to date.

Changes applied before test

commit 7e2516b175eceba20617e4a43441029beeef528f
Author: Franck Bret <franck.bret@octobus.net>
Date:   Wed Jun 29 15:53:06 2022 +0200

    Arch, use **kwargs on task initialisation instead of named args.
    
    This fix an issue discovered while testing loader on docker environment,
    error was (load_arch() got an unexpected keyword argument
    'lister_name')
    
    Related T4233

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/810/ for more details.

Harbormaster completed remote builds in B30129: Diff 29043.Jun 29 2022, 3:59 PM

franckbret requested review of this revision.Jun 29 2022, 3:59 PM

vlorentz accepted this revision.Jun 29 2022, 4:06 PM

This revision is now accepted and ready to land.Jun 29 2022, 4:06 PM

Rebase

Build is green

Patch application report for D8051 (id=29048)

Rebasing onto b0e3335df7...

Current branch diff-target is up to date.

Changes applied before test

commit 01547b8edff51b03294aa7cb556a7fe34a15788d
Author: Franck Bret <franck.bret@octobus.net>
Date:   Wed Jun 29 15:53:06 2022 +0200

    Arch, use **kwargs on task initialisation instead of named args.
    
    This fix an issue discovered while testing loader on docker environment,
    error was (load_arch() got an unexpected keyword argument
    'lister_name')
    
    Related T4233

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/812/ for more details.

Harbormaster completed remote builds in B30134: Diff 29048.Jun 29 2022, 5:19 PM

Closed by commit rDLDBASE01547b8edff5: Arch, use **kwargs on task initialisation instead of named args. (authored by franckbret). · Explain WhyJun 29 2022, 5:20 PM

This revision was automatically updated to reflect the committed changes.

franckbret added a commit: rDLDBASE01547b8edff5: Arch, use **kwargs on task initialisation instead of named args..