Page MenuHomeSoftware Heritage

Install `swh provenance origin from-journal` cli and tests
ClosedPublic

Authored by ardumont on Jun 22 2022, 3:48 PM.

Details

Summary

As a consequence, this introduces the use of swh.journal in the provenance swh
requirements.

This also:

  • deprecates the swh provenance iter-origins
  • in favor of the new swh provenance origin from-csv cli
  • Add tests around those CLIs ^

Co-authored with @douardda (author of the initial commit)

Test Plan

tox

Diff Detail

Repository
rDENV Development environment
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29998
Build 46894: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Build has FAILED

Patch application report for D8023 (id=28911)

Rebasing onto 80434e3b21...

Current branch diff-target is up to date.
Changes applied before test
commit db7be64ef1d574441ecb475597f617f8af5d7c31
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/607/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/607/console

Build is green

Patch application report for D8023 (id=28911)

Rebasing onto 80434e3b21...

Current branch diff-target is up to date.
Changes applied before test
commit db7be64ef1d574441ecb475597f617f8af5d7c31
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/608/ for more details.

Build was aborted

Patch application report for D8023 (id=28966)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/614/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/614/console

Build was aborted

Patch application report for D8023 (id=28966)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/615/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/615/console

Build was aborted

Patch application report for D8023 (id=28966)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/616/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/616/console

Build was aborted

Patch application report for D8023 (id=28966)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/617/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/617/console

Build was aborted

It was fine prior to the rebase (and master build is fine).
I've no idea what's happening nor the patience to unstuck it currently.

Build was aborted

Patch application report for D8023 (id=28966)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/618/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/618/console

Build was aborted

Patch application report for D8023 (id=28985)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/619/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/619/console

wip tryout (drop rabbitmq from fixture) to check if that still hangs or not

Build is green

Patch application report for D8023 (id=28988)

Could not rebase; Attempt merge onto f5f7413663...

Updating f5f7413..89caa89
Fast-forward
 mypy.ini                                    |  4 +-
 requirements-swh.txt                        |  1 +
 requirements-test.txt                       |  1 +
 requirements.txt                            |  1 +
 swh/provenance/cli.py                       | 77 ++++++++++++++++++++++++++-
 swh/provenance/journal_client.py            | 22 ++++++++
 swh/provenance/postgresql/provenance.py     |  5 ++
 swh/provenance/tests/conftest.py            |  2 +-
 swh/provenance/tests/data/origins.csv       |  1 +
 swh/provenance/tests/test_cli.py            | 59 ++++++++++++++++++++-
 swh/provenance/tests/test_journal_client.py | 81 +++++++++++++++++++++++++++++
 swh/provenance/tests/test_utils.py          | 31 +++++++++++
 12 files changed, 280 insertions(+), 5 deletions(-)
 create mode 100644 swh/provenance/journal_client.py
 create mode 100644 swh/provenance/tests/data/origins.csv
 create mode 100644 swh/provenance/tests/test_journal_client.py
 create mode 100644 swh/provenance/tests/test_utils.py
Changes applied before test
commit 89caa898182ccf8316225b51df9b56a9110a152b
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 11:45:09 2022 +0200

    wip workaround build

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/620/ for more details.

including the right amount of commits

Build is green

Patch application report for D8023 (id=28989)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 89caa898182ccf8316225b51df9b56a9110a152b
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 11:45:09 2022 +0200

    wip workaround build

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/621/ for more details.

  • Tentatively work around the rabbitmq initialization.
This revision is now accepted and ready to land.Jun 29 2022, 4:42 PM

Build has FAILED

Patch application report for D8023 (id=29046)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 4d272aec6d8cb72dd87a69855f2b8f5f14c5f295
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 15:59:51 2022 +0200

    Tentatively work around the rabbitmq initialization.

commit 89caa898182ccf8316225b51df9b56a9110a152b
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 11:45:09 2022 +0200

    wip workaround build

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/622/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/622/console

Build was aborted

Patch application report for D8023 (id=29046)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 4d272aec6d8cb72dd87a69855f2b8f5f14c5f295
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 15:59:51 2022 +0200

    Tentatively work around the rabbitmq initialization.

commit 89caa898182ccf8316225b51df9b56a9110a152b
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 11:45:09 2022 +0200

    wip workaround build

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/623/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/623/console

  • Tentatively work around the rabbitmq initialization 3/n

Build was aborted

Patch application report for D8023 (id=29047)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 297d7621398e8df90efeafa4d901cbb36f0cfa0a
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 15:59:51 2022 +0200

    Tentatively work around the rabbitmq initialization.

commit 89caa898182ccf8316225b51df9b56a9110a152b
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 11:45:09 2022 +0200

    wip workaround build

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/624/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/624/console

  • Tentatively work around the rabbitmq tests build failures 4/n

Build was aborted

Patch application report for D8023 (id=29050)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 972e4645a5e57f9543a65d36af049e20451c5c57
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 15:59:51 2022 +0200

    Tentatively work around the rabbitmq tests build failures

commit 89caa898182ccf8316225b51df9b56a9110a152b
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 11:45:09 2022 +0200

    wip workaround build

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/625/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/625/console

  • Tentatively work around the rabbitmq tests build failures 5/n

Build was aborted

Patch application report for D8023 (id=29051)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 709a55c3ed638d4ebf608435275b11b488efaffa
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 17:44:36 2022 +0200

    Tentatively work around the rabbitmq tests build failures 5/n

commit 972e4645a5e57f9543a65d36af049e20451c5c57
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 15:59:51 2022 +0200

    Tentatively work around the rabbitmq tests build failures

commit 89caa898182ccf8316225b51df9b56a9110a152b
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 11:45:09 2022 +0200

    wip workaround build

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/626/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/626/console

I'm of a mind of just push it and check whether that's not some discrepancy with the master build somehow.
Master build is fine and local build as well.

Build was aborted

Patch application report for D8023 (id=29053)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/627/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/627/console

ardumont added inline comments.
swh/provenance/postgresql/provenance.py
80 ↗(On Diff #29053)

@olasd mentions this could be the source of the failing build.

  • Drop self.conn shenanigans (tests no longer stuck but journal client tests are not happy)
  • Explicitly manage the provenance storage connection in journal client
swh/provenance/postgresql/provenance.py
80 ↗(On Diff #29053)

and instead i should wrap the client call in a with provenance: (which explicitly opens/closes the connection to the backend storage).

Build was aborted

Patch application report for D8023 (id=29055)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit fa30351e8b60da52f58d4faf73b312f62c9f8048
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 29 18:41:25 2022 +0200

    Drop self.conn shenanigans
    
    I recalled that without it, db transactions in (journal?) tests would fail...

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/628/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/628/console

Build was aborted

Patch application report for D8023 (id=29056)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit a721125c2a0a3bb9c400fc9fe31d7b9b82243a9c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 18:44:57 2022 +0200

    Explicitly manage the provenance storage connection in journal client
    
    Doing it implicitly makes pytest fixture teardown impossible because of
    object references that are held for too long, preventing the postgresql
    server from shutting down.

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/630/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/630/console

  • Force rabbitmq server termination in tests

Build was aborted

Patch application report for D8023 (id=29057)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 0cc365f242b325c34b88f3c79ecad18b4693d56c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 19:20:04 2022 +0200

    Force rabbitmq server termination in tests

commit a721125c2a0a3bb9c400fc9fe31d7b9b82243a9c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 18:44:57 2022 +0200

    Explicitly manage the provenance storage connection in journal client
    
    Doing it implicitly makes pytest fixture teardown impossible because of
    object references that are held for too long, preventing the postgresql
    server from shutting down.

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/631/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/631/console

swh/provenance/tests/test_journal_client.py
67 ↗(On Diff #29057)

I explicitely drop that part as i noticed discrepancies in storage instances when using that ^ in initial runs.
(which then fails the assertion below since it's not the same storages).

swh/provenance/tests/test_journal_client.py
67 ↗(On Diff #29057)

as a heads up ^

Build is green

Patch application report for D8023 (id=29060)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 8c44dcb5280e253000bc5536387d30551b495327
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Jun 30 10:50:20 2022 +0200

    Isolate journal tests

commit 0cc365f242b325c34b88f3c79ecad18b4693d56c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 19:20:04 2022 +0200

    Force rabbitmq server termination in tests

commit a721125c2a0a3bb9c400fc9fe31d7b9b82243a9c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 18:44:57 2022 +0200

    Explicitly manage the provenance storage connection in journal client
    
    Doing it implicitly makes pytest fixture teardown impossible because of
    object references that are held for too long, preventing the postgresql
    server from shutting down.

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/632/ for more details.

Pass {posargs} to both pytest runs

tox.ini
10–16 ↗(On Diff #29065)

please add a comment to explain it's necessary because of the rdkafka teardown issues

Build is green

Patch application report for D8023 (id=29065)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 0facfc3fcd58f4320e547adb818e54925729d618
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Jun 30 10:50:20 2022 +0200

    Isolate journal tests

commit 0cc365f242b325c34b88f3c79ecad18b4693d56c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 19:20:04 2022 +0200

    Force rabbitmq server termination in tests

commit a721125c2a0a3bb9c400fc9fe31d7b9b82243a9c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 18:44:57 2022 +0200

    Explicitly manage the provenance storage connection in journal client
    
    Doing it implicitly makes pytest fixture teardown impossible because of
    object references that are held for too long, preventing the postgresql
    server from shutting down.

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/633/ for more details.

Add explanatory comment for the tests split in tox.ini

Build is green

Patch application report for D8023 (id=29066)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 0b38286f53013491f3d00c8747595977412d4f6e
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Jun 30 10:50:20 2022 +0200

    Isolate journal tests

commit 0cc365f242b325c34b88f3c79ecad18b4693d56c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 19:20:04 2022 +0200

    Force rabbitmq server termination in tests

commit a721125c2a0a3bb9c400fc9fe31d7b9b82243a9c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 18:44:57 2022 +0200

    Explicitly manage the provenance storage connection in journal client
    
    Doing it implicitly makes pytest fixture teardown impossible because of
    object references that are held for too long, preventing the postgresql
    server from shutting down.

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/634/ for more details.

Ensure coverage results are kept incrementally

Build is green

Patch application report for D8023 (id=29068)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit 1934605d037722db70199f25a9a2fd2b50f97f4e
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Jun 30 10:50:20 2022 +0200

    Isolate journal tests

commit 0cc365f242b325c34b88f3c79ecad18b4693d56c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 19:20:04 2022 +0200

    Force rabbitmq server termination in tests

commit a721125c2a0a3bb9c400fc9fe31d7b9b82243a9c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 18:44:57 2022 +0200

    Explicitly manage the provenance storage connection in journal client
    
    Doing it implicitly makes pytest fixture teardown impossible because of
    object references that are held for too long, preventing the postgresql
    server from shutting down.

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/635/ for more details.

Drop useless rabbitmq server change

Build is green

Patch application report for D8023 (id=29069)

Rebasing onto f5f7413663...

Current branch diff-target is up to date.
Changes applied before test
commit af616497e108810a1a8f8a93753710e4c6d087ca
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Jun 30 10:50:20 2022 +0200

    Isolate journal tests

commit a721125c2a0a3bb9c400fc9fe31d7b9b82243a9c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 29 18:44:57 2022 +0200

    Explicitly manage the provenance storage connection in journal client
    
    Doing it implicitly makes pytest fixture teardown impossible because of
    object references that are held for too long, preventing the postgresql
    server from shutting down.

commit a23c22827dfa262f89d0f300d39c954e9d703a03
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 22 12:40:38 2022 +0200

    Install `swh provenance origin from-journal` cli and tests
    
    As a consequence, this introduces the use of swh.journal in the provenance swh
    requirements.
    
    This also:
    - deprecates the `swh provenance iter-origins`
    - in favor of the new `swh provenance origin from-csv` cli
    - Add tests around those CLIs ^

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/636/ for more details.