Page MenuHomeSoftware Heritage

Initialize base metadata fetcher + github
ClosedPublic

Authored by vlorentz on Apr 22 2022, 3:07 PM.

Details

Test Plan

Will fail, because this depends on D7630 and D7632 being released

Diff Detail

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 22 2022, 3:07 PM
Harbormaster failed remote builds in B28693: Diff 27639!

Build has FAILED

Patch application report for D7633 (id=27649)

Rebasing onto bfc39f3580...

Current branch diff-target is up to date.
Changes applied before test
commit f7a18d19c9b16f7bb90042e4d49c2a3209c25485
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 15:04:22 2022 +0200

    Initialize base metadata fetcher + github

Link to build: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/1/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/1/console

ardumont added inline comments.
requirements-swh.txt
2

so i guess we'll have a requirement change here, something like?

swh/loader/metadata/base.py
103–104
108

We are mostly using the imperative form nowadays, aren't we?

requirements-swh.txt
2

currently, no.

And extras *add* features, they don't make it so *only* the mentioned feature is installed

swh/loader/metadata/base.py
103–104

wow

108

I don't know

swh/loader/metadata/base.py
182

is the print useful as well?

swh/loader/metadata/tests/test_github.py
72–94

?

swh/loader/metadata/base.py
182

yes, it makes flake8 not complain about the unused var

lgtm, couple of remarks inline.

swh/loader/metadata/tests/test_github.py
49

you can drop it.

This revision is now accepted and ready to land.Apr 25 2022, 5:24 PM
swh/loader/metadata/base.py
103–104

ikr ;)

Build has FAILED

Patch application report for D7633 (id=27678)

Rebasing onto bfc39f3580...

Current branch diff-target is up to date.
Changes applied before test
commit c742edd752a68eabc86a4c6c54ee1eed9cd5f8e3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 15:04:22 2022 +0200

    Initialize base metadata fetcher + github

Link to build: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/2/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/2/console

requirements-swh.txt
2

fine

swh/loader/metadata/tests/test_github.py
49

ping?

(that's not for type this time, isn't it?)

swh/loader/metadata/tests/test_github.py
49

it's still for flake8

Build has FAILED

Patch application report for D7633 (id=27678)

Rebasing onto bfc39f3580...

Current branch diff-target is up to date.
Changes applied before test
commit c742edd752a68eabc86a4c6c54ee1eed9cd5f8e3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 15:04:22 2022 +0200

    Initialize base metadata fetcher + github

Link to build: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/3/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/3/console

Build has FAILED

Patch application report for D7633 (id=27711)

Rebasing onto bfc39f3580...

Current branch diff-target is up to date.
Changes applied before test
commit 46e9be8a9f9ba70a24f982c5e4448f7cb4dde6f7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 15:04:22 2022 +0200

    Initialize base metadata fetcher + github

Link to build: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/4/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/4/console

Build is green

Patch application report for D7633 (id=27713)

Rebasing onto bfc39f3580...

Current branch diff-target is up to date.
Changes applied before test
commit aa0af83a5e04dfc938eeeefca5f92756fac7dca9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 22 15:04:22 2022 +0200

    Initialize base metadata fetcher + github

See https://jenkins.softwareheritage.org/job/DLDMD/job/tests-on-diff/5/ for more details.