Page MenuHomeSoftware Heritage

Fix deposit metadata retrieval in moderation view
ClosedPublic

Authored by ardumont on Apr 8 2022, 12:36 PM.

Details

Summary

Hot-patch in staging, it is ok now.

Related to T4125

D7533 was not needed indeed the right fix

Test Plan

Hotpatch staging and it's now displaying the metadata.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28257
Build 44240: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 44239: arc lint + arc unit

Event Timeline

ardumont edited the summary of this revision. (Show Details)
ardumont added inline comments.
swh/web/admin/deposit.py
118

Note it should already be present here... (provided by the deposit listing api).
But i won't spend more time on this, i just want to unstuck the functionality
to work.

Plus that will get scratch soon by @anlambert with the optimization work he is
currently working on (that code will end up in the deposit server).

Build is green

Patch application report for D7535 (id=27324)

Rebasing onto bdee9fe46e...

Current branch diff-target is up to date.
Changes applied before test
commit c020acd4d5953535a6a91bf2f0ac1102bf1bcd9e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Apr 8 12:03:25 2022 +0200

    Fix deposit metadata retrieval in moderation view
    
    Related to T4125

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1701/ for more details.

Build is green

Patch application report for D7535 (id=27325)

Rebasing onto bdee9fe46e...

Current branch diff-target is up to date.
Changes applied before test
commit 932b955afe1245e9b83cf7816ec15bb4176cb710
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Apr 8 12:03:25 2022 +0200

    Fix deposit metadata retrieval in moderation view
    
    Related to T4125

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1702/ for more details.

This revision is now accepted and ready to land.Apr 8 2022, 1:28 PM
This revision was landed with ongoing or failed builds.Apr 8 2022, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7535 (id=27331)

Rebasing onto 86328cff68...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-1704-D7535.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1704/ for more details.