Differential D7213

common/swh_templatetags: Fix parsing issue in urlize_header_links
ClosedPublic
Actions

Authored by anlambert on Feb 21 2022, 5:43 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3967: "Link" header is not properly displayed in apidoc when it contains []

Commits

rDWAPPS937a1d59c592: common/swh_templatetags: Fix parsing issue in urlize_header_links

Summary

If one of the URL links to parse contains a comma character, the parsing
was incorrect.

So fix that issue by updating the regexp use to format the links for
display in the API Web UI.

Related to T3967

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27014
Build 42241: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42240: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 21 2022, 5:43 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 21 2022, 5:43 PM

Build has FAILED

Patch application report for D7213 (id=26143)

Rebasing onto 55aa143db8...

Current branch diff-target is up to date.

Changes applied before test

commit 937a1d59c592e2effc4d1131a06897df19ee8cfa
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Feb 21 17:38:13 2022 +0100

    common/swh_templatetags: Fix parsing issue in urlize_header_links
    
    If one of the URL links to parse contains a comma character, the parsing
    was incorrect.
    
    So fix that issue by updating the regexp use to format the links for
    display in the API Web UI.
    
    Related to T3967

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1394/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1394/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 21 2022, 5:45 PM

Harbormaster failed remote builds in B27014: Diff 26143!

Build is green

Patch application report for D7213 (id=26143)

Rebasing onto 55aa143db8...

Current branch diff-target is up to date.

Changes applied before test

commit 937a1d59c592e2effc4d1131a06897df19ee8cfa
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Feb 21 17:38:13 2022 +0100

    common/swh_templatetags: Fix parsing issue in urlize_header_links
    
    If one of the URL links to parse contains a comma character, the parsing
    was incorrect.
    
    So fix that issue by updating the regexp use to format the links for
    display in the API Web UI.
    
    Related to T3967

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1395/ for more details.

Harbormaster completed remote builds in B27014: Diff 26143.Feb 21 2022, 6:16 PM

anlambert requested review of this revision.Feb 21 2022, 6:16 PM

ardumont accepted this revision.Feb 21 2022, 6:27 PM

This revision is now accepted and ready to land.Feb 21 2022, 6:27 PM

Closed by commit rDWAPPS937a1d59c592: common/swh_templatetags: Fix parsing issue in urlize_header_links (authored by anlambert). · Explain WhyFeb 22 2022, 11:18 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS937a1d59c592: common/swh_templatetags: Fix parsing issue in urlize_header_links.