Page MenuHomeSoftware Heritage
Differential D7050

Fix unique index definition for path to avoid error with large values
ClosedPublic
Actions

Authored by aeviso on Jan 31 2022, 1:01 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDPROV4dd24fd5aba5: Fix unique index definition for path to avoid error with large values

Diff Detail

Event Timeline

aeviso created this revision.Jan 31 2022, 1:01 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 31 2022, 1:01 PM
swh-public-ci added a comment.Jan 31 2022, 1:07 PM

Build is green

Patch application report for D7050 (id=25564)

Could not rebase; Attempt merge onto dfac07f890...

Updating dfac07f..f2993ce
Fast-forward
 requirements-swh.txt                 |  1 +
 sql/upgrades/003.sql                 | 15 ++++++++++++
 swh/provenance/__init__.py           |  9 ++++++-
 swh/provenance/archive.py            |  3 +--
 swh/provenance/postgresql/archive.py |  2 +-
 swh/provenance/sql/30-schema.sql     |  6 ++---
 swh/provenance/sql/60-indexes.sql    |  2 ++
 swh/provenance/storage/archive.py    |  2 +-
 swh/provenance/swhgraph/__init__.py  |  0
 swh/provenance/swhgraph/archive.py   | 46 ++++++++++++++++++++++++++++++++++++
 10 files changed, 78 insertions(+), 8 deletions(-)
 create mode 100644 sql/upgrades/003.sql
 create mode 100644 swh/provenance/swhgraph/__init__.py
 create mode 100644 swh/provenance/swhgraph/archive.py
Changes applied before test
commit f2993ce4785158350c141397d1f04e5531823fbd
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jan 31 12:56:30 2022 +0100

    Fix unique index definition for path to avoid error with large values

commit f2301c188729ca1d67618cb05edb27f976a4914d
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jan 20 16:08:32 2022 +0100

    Add partial implementation of `ArchiveGraph` class

commit f2cbe1c38fc652c0335a882d2f0982bc3943aaf4
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jan 20 15:35:43 2022 +0100

    Remove ordered result constrain from `snapshot_get_heads`
    
    It is not require anymore after simplifying the origin-revision
    layer algorithm.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/566/ for more details.

Harbormaster completed remote builds in B26394: Diff 25564.Jan 31 2022, 1:07 PM
aeviso requested review of this revision.Jan 31 2022, 1:07 PM
aeviso updated this revision to Diff 25566.Jan 31 2022, 4:11 PM

rebase

swh-public-ci added a comment.Jan 31 2022, 4:16 PM

Build is green

Patch application report for D7050 (id=25566)

Could not rebase; Attempt merge onto dfac07f890...

Updating dfac07f..c348456
Fast-forward
 MANIFEST.in                              |  4 ++-
 requirements-swh.txt                     |  1 +
 sql/upgrades/003.sql                     | 15 +++++++++++
 swh/provenance/__init__.py               |  9 ++++++-
 swh/provenance/archive.py                |  3 +--
 swh/provenance/postgresql/archive.py     |  2 +-
 swh/provenance/sql/10-superuser-init.sql |  3 +++
 swh/provenance/sql/30-schema.sql         |  6 ++---
 swh/provenance/sql/60-indexes.sql        |  1 +
 swh/provenance/storage/archive.py        |  2 +-
 swh/provenance/swhgraph/__init__.py      |  0
 swh/provenance/swhgraph/archive.py       | 46 ++++++++++++++++++++++++++++++++
 swh/provenance/tests/conftest.py         |  7 +++--
 swh/provenance/tests/test_cli.py         |  3 +++
 14 files changed, 91 insertions(+), 11 deletions(-)
 create mode 100644 sql/upgrades/003.sql
 create mode 100644 swh/provenance/sql/10-superuser-init.sql
 create mode 100644 swh/provenance/swhgraph/__init__.py
 create mode 100644 swh/provenance/swhgraph/archive.py
Changes applied before test
commit c348456f8ab501399d8bb775f55b6b576ca3a154
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jan 31 12:56:30 2022 +0100

    Fix unique index definition for path to avoid error with large values

commit f2301c188729ca1d67618cb05edb27f976a4914d
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jan 20 16:08:32 2022 +0100

    Add partial implementation of `ArchiveGraph` class

commit f2cbe1c38fc652c0335a882d2f0982bc3943aaf4
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jan 20 15:35:43 2022 +0100

    Remove ordered result constrain from `snapshot_get_heads`
    
    It is not require anymore after simplifying the origin-revision
    layer algorithm.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/567/ for more details.

Harbormaster completed remote builds in B26396: Diff 25566.Jan 31 2022, 4:16 PM
aeviso edited the summary of this revision. (Show Details)Jan 31 2022, 4:23 PM
aeviso removed a parent revision: D6990: Add partial implementation of `ArchiveGraph` class.
aeviso updated this revision to Diff 25567.Jan 31 2022, 4:24 PM

rebase

swh-public-ci added a comment.Jan 31 2022, 4:29 PM

Build is green

Patch application report for D7050 (id=25567)

Rebasing onto dfac07f890...

Current branch diff-target is up to date.
Changes applied before test
commit bbab4c65c1b6b91cb994e49a198721c604d09c4e
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jan 31 12:56:30 2022 +0100

    Fix unique index definition for path to avoid error with large values

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/568/ for more details.

Harbormaster completed remote builds in B26397: Diff 25567.Jan 31 2022, 4:29 PM
aeviso added a child revision: D6990: Add partial implementation of `ArchiveGraph` class.Jan 31 2022, 4:34 PM
ardumont accepted this revision.Jan 31 2022, 4:52 PM
ardumont added a subscriber: ardumont.

lgtm, couple of remarks/suggestions inline.

sql/upgrades/003.sql
7

that sql command won't work if not used as admin.
I think it's ok to drop it from the migration script.
(keep it in the next 10-superuser-init.sql though).

swh/provenance/tests/conftest.py
108

drop the print ;)

swh/provenance/tests/test_cli.py
101

can't you reuse the fixture defined earlier?

This revision is now accepted and ready to land.Jan 31 2022, 4:52 PM
aeviso updated this revision to Diff 25573.Jan 31 2022, 4:57 PM

rebase

aeviso marked 3 inline comments as done.Jan 31 2022, 4:59 PM
aeviso added inline comments.
swh/provenance/tests/test_cli.py
101

that fixture has an already initialized database, it's not suitable for this particular test

This revision was landed with ongoing or failed builds.Jan 31 2022, 4:59 PM
Closed by commit rDPROV4dd24fd5aba5: Fix unique index definition for path to avoid error with large values (authored by aeviso). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeviso marked an inline comment as done.
aeviso added a commit: rDPROV4dd24fd5aba5: Fix unique index definition for path to avoid error with large values.
swh-public-ci added a comment.Jan 31 2022, 5:03 PM

Build is green

Patch application report for D7050 (id=25573)

Rebasing onto dfac07f890...

Current branch diff-target is up to date.
Changes applied before test
commit 4dd24fd5aba526b116cd98c593fd2ba7c2866fd2
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jan 31 12:56:30 2022 +0100

    Fix unique index definition for path to avoid error with large values

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/572/ for more details.

Harbormaster completed remote builds in B26402: Diff 25573.Jan 31 2022, 5:03 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
4 lines--
sql/
upgrades/
15 lines--
swh/
provenance/
sql/
3 lines--
6 lines--
1 line--
tests/
7 lines100%
Loading...
3 lines100%
Loading...

Diff 25566

View Options

MANIFEST.in

Loading...
View Options

sql/upgrades/003.sql

Loading...
View Options

swh/provenance/sql/10-superuser-init.sql

Loading...
View Options

swh/provenance/sql/30-schema.sql

Loading...
View Options

swh/provenance/sql/60-indexes.sql

Loading...
View Options

swh/provenance/tests/conftest.py

Loading...
View Options

swh/provenance/tests/test_cli.py

Loading...
About · Developer information · Legal