response.content_type is set by Dulwich, but isn't part of urllib3's
HTTPResponse, so we shouldn't rely on it.
(And it makes mypy complain when the 'types-urllib3' package is installed)
Details
Details
- Reviewers
anlambert olasd - Group Reviewers
Reviewers - Commits
- rDLDGd7481af6b33c: Fix typing issue
Diff Detail
Diff Detail
- Repository
- rDLDG Git loader
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25893 Build 40468: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 40467: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D6900 (id=25018)
Rebasing onto 0cc96c25ab...
Current branch diff-target is up to date.
Changes applied before test
commit c56f6126703aeaabd7b2a37e0960f39e5e7257d7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Jan 10 17:01:34 2022 +0100
Fix typing issue
response.content_type is set by Dulwich, but isn't part of urllib3's
HTTPResponse, so we shouldn't rely on it.
(And it makes mypy complain when the 'types-urllib3' package is installed)Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/163/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/163/console
Comment Actions
Reading the rest of this file, we're not using features from dulwich's HttpGitClient all that much, it would probably make sense to replace it altogether with a basic requests session?
Comment Actions
For the record, I preferred to use the features available in dulwich when implementing this instead of adding a new dependency to requests in the loader.
But yes, this could be easily ported to requests.
Comment Actions
Effectively requests is in our "standard library" (via swh.core[http]), so it's not a big deal.
Either way, we need parens around the or statement (and has higher precedence) though.
Comment Actions
Build is green
Patch application report for D6900 (id=25023)
Rebasing onto 0cc96c25ab...
Current branch diff-target is up to date.
Changes applied before test
commit d7481af6b33c3b7ddaad31f1801074d1525a7af2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Jan 10 17:01:34 2022 +0100
Fix typing issue
response.content_type is set by Dulwich, but isn't part of urllib3's
HTTPResponse, so we shouldn't rely on it.
(And it makes mypy complain when the 'types-urllib3' package is installed)See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/166/ for more details.