Page MenuHomeSoftware Heritage

debian: Update extra_loader_arguments dict produced ListedOrigin models
ClosedPublic

Authored by anlambert on Dec 3 2021, 11:19 AM.

Details

Summary

Remove no longer used date parameter in extra_loader_arguments.

Related to D6737

Related to T2400

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6738 (id=24469)

Could not rebase; Attempt merge onto 5f567b3c34...

Updating 5f567b3..4ff3e44
Fast-forward
 swh/lister/debian/lister.py            |  8 ++++++--
 swh/lister/debian/tests/test_lister.py | 17 +++++++++++++----
 2 files changed, 19 insertions(+), 6 deletions(-)
Changes applied before test
commit 4ff3e44643f3f549e6dcf054b048fa92094fc5da
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 2 20:07:37 2021 +0100

    debian: Update extra_loader_arguments dict produced ListedOrigin models
    
    Remove no longer used date parameter in extra_loader_arguments.
    
    Related to T2400

commit 46425917c25e4d58cff6ab8870eaddc13180bf92
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 2 17:19:08 2021 +0100

    debian: Add missing file URIs in lister output
    
    For a given package, the debian lister generates a dictionary mapping
    distribution and version to a list of files to be processed by the
    debian loader.
    
    For each file to process, the debian loader expects to find an URI
    in order to download it and then use its content to ingest package
    source code into the archive.
    
    However, it turns out these URIs were not computed by the lister
    in its current implementation making any debian loading task fail
    due to these missing info.
    
    So add the computation of these URIS and ensure they will be provided
    in the debian loader input parameters.
    
    Related to T2400

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/426/ for more details.

ardumont added a subscriber: ardumont.

Yes, thanks.

also, "lol", it's None and ignored in the loader..., oopsy.

This revision is now accepted and ready to land.Dec 3 2021, 11:24 AM