Differential D6735

debian: Add missing file URIs in lister output
ClosedPublic
Actions

Authored by anlambert on Dec 2 2021, 5:31 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2400: Ingest current and historical Ubuntu releases

Commits

rDLS46425917c25e: debian: Add missing file URIs in lister output

Summary

For a given package, the debian lister generates a dictionary mapping
distribution and version to a list of files to be processed by the
debian loader.

For each file to process, the debian loader expects to find an URI
in order to download it and then use its content to ingest package
source code into the archive.

However, it turns out these URIs were not computed by the lister
in its current implementation making any debian loading task fail
due to these missing info.

So add the computation of these URIS and ensure they will be provided
in the debian loader input parameters.

Related to T2400

Diff Detail

Repository

rDLS Listers

Branch

debian-loader-add-missing-files-uris

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25336
Build 39602: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39601: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 2 2021, 5:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 2 2021, 5:31 PM

Build is green

Patch application report for D6735 (id=24462)

Rebasing onto 5f567b3c34...

Current branch diff-target is up to date.

Changes applied before test

commit 46425917c25e4d58cff6ab8870eaddc13180bf92
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 2 17:19:08 2021 +0100

    debian: Add missing file URIs in lister output
    
    For a given package, the debian lister generates a dictionary mapping
    distribution and version to a list of files to be processed by the
    debian loader.
    
    For each file to process, the debian loader expects to find an URI
    in order to download it and then use its content to ingest package
    source code into the archive.
    
    However, it turns out these URIs were not computed by the lister
    in its current implementation making any debian loading task fail
    due to these missing info.
    
    So add the computation of these URIS and ensure they will be provided
    in the debian loader input parameters.
    
    Related to T2400

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/425/ for more details.

Harbormaster completed remote builds in B25336: Diff 24462.Dec 2 2021, 5:34 PM

anlambert requested review of this revision.Dec 2 2021, 5:34 PM