This mapping is no longer needed since rDGRPH0b33cff0d228, so we stop writing
it to disk.
Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Commits
- rDGRPHd0dbfda9a775: Stop writing swhid2node.bin maps
Diff Detail
Diff Detail
- Repository
- rDGRPH Compressed graph representation
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25208 Build 39390: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 39389: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6699 (id=24334)
Rebasing onto 0b33cff0d2...
Current branch diff-target is up to date.
Changes applied before test
commit d0dbfda9a775f031f3e4e29169e537a7ad91d21e
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date: Fri Nov 26 17:32:45 2021 +0100
Stop writing swhid2node.bin mapsSee https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/142/ for more details.
Comment Actions
Looks overall ok to me, but I miss a few "why?" here:
- the "why stop writing this file" should be in the commit message,
- why the need for SortOutputHandler attributes to become final?
Comment Actions
why the need for SortOutputHandler attributes to become final?
No need, it's just a default warning when a field in a class can become final. I don't know how much of a good practice it is, maybe I could remove the warning.