Page MenuHomeSoftware Heritage
Differential D6673

Add an introduction to the vault documentation
ClosedPublic
Actions

Authored by vlorentz on Nov 23 2021, 3:47 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T3605: Document the vault architecture
Commits
rDVAU35e4fd7378b7: Add an introduction to the vault documentation

Diff Detail

Unit TestsFailed
View All

TimeTest
185 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestRevisionCooker::test_revision_filtered_objects[cook_extract_revision_git_bare]
self = <swh.vault.tests.test_cookers.TestRevisionCooker object at 0x7f04f93aa908> git_loader = <function git_loader.<locals>._create_loader at 0x7f04f9614d08> cook_extract_revision = <function cook_extract_revision_git_bare at 0x7f04fce63598>
156 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestRevisionCooker::test_revision_null_fields[cook_extract_revision_git_bare]
self = <swh.vault.tests.test_cookers.TestRevisionCooker object at 0x7f04f95266d8> git_loader = <function git_loader.<locals>._create_loader at 0x7f04f94a39d8> cook_extract_revision = <function cook_extract_revision_git_bare at 0x7f04fce63598>
337 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestRevisionCooker::test_revision_simple[cook_extract_revision_git_bare]
self = <swh.vault.tests.test_cookers.TestRevisionCooker object at 0x7f04fb7385c0> git_loader = <function git_loader.<locals>._create_loader at 0x7f04fb822e18> cook_extract_revision = <function cook_extract_revision_git_bare at 0x7f04fce63598>
125 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestRevisionCooker::test_revision_submodule[cook_extract_revision_git_bare-False]
self = <swh.vault.tests.test_cookers.TestRevisionCooker object at 0x7f04f93f5be0> swh_storage = <swh.storage.postgresql.storage.Storage object at 0x7f04f93f5320> cook_extract_revision = <function cook_extract_revision_git_bare at 0x7f04fce63598>
123 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_cookers.TestRevisionCooker::test_revision_submodule[cook_extract_revision_git_bare-True]
self = <swh.vault.tests.test_cookers.TestRevisionCooker object at 0x7f04f94e80f0> swh_storage = <swh.storage.postgresql.storage.Storage object at 0x7f04f94e85f8> cook_extract_revision = <function cook_extract_revision_git_bare at 0x7f04fce63598>
View Full Test Results (24 Failed · 84 Passed)

Event Timeline

vlorentz created this revision.Nov 23 2021, 3:47 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 23 2021, 3:47 PM
swh-public-ci added a comment.Nov 23 2021, 3:48 PM

Build has FAILED

Patch application report for D6673 (id=24244)

Could not rebase; Attempt merge onto 1c83b82b49...

Updating 1c83b82..1087c2f
Fast-forward
 README.md                     |  9 --------
 docs/README.rst               | 49 +++++++++++++++++++++++++++++++++++++++++++
 docs/index.rst                |  7 +------
 swh/vault/cookers/git_bare.py |  7 ++++++-
 4 files changed, 56 insertions(+), 16 deletions(-)
 delete mode 100644 README.md
 create mode 100644 docs/README.rst
Changes applied before test
commit 1087c2fd42ea73aafad72e2309d3f780ff42e76a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:47:01 2021 +0100

    Add an introduction to the vault documentation

commit dd47302b5571572b8d3b4f048903c7f9f624ba24
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:22:31 2021 +0100

    git_bare: Fix counter of processed objects
    
    self._seen contains also all the objects on the todo-stacks,
    so it's incorrect to use it here.

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/190/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/190/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 23 2021, 3:48 PM
Harbormaster failed remote builds in B25120: Diff 24244!
vlorentz updated this revision to Diff 24247.Nov 23 2021, 3:50 PM

update setup.py

swh-public-ci added a comment.Nov 23 2021, 3:50 PM

Build has FAILED

Patch application report for D6673 (id=24247)

Could not rebase; Attempt merge onto 1c83b82b49...

Updating 1c83b82..33a3084
Fast-forward
 README.md                     |  9 --------
 docs/README.rst               | 49 +++++++++++++++++++++++++++++++++++++++++++
 docs/index.rst                |  7 +------
 setup.py                      |  4 ++--
 swh/vault/cookers/git_bare.py |  7 ++++++-
 5 files changed, 58 insertions(+), 18 deletions(-)
 delete mode 100644 README.md
 create mode 100644 docs/README.rst
Changes applied before test
commit 33a3084f3f39ebc728e7e4fa47a62d7cf7022498
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:47:01 2021 +0100

    Add an introduction to the vault documentation

commit dd47302b5571572b8d3b4f048903c7f9f624ba24
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:22:31 2021 +0100

    git_bare: Fix counter of processed objects
    
    self._seen contains also all the objects on the todo-stacks,
    so it's incorrect to use it here.

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/192/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/192/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 23 2021, 3:50 PM
Harbormaster failed remote builds in B25123: Diff 24247!
vlorentz updated this revision to Diff 24249.Nov 23 2021, 3:55 PM

add missing README symlink

swh-public-ci added a comment.Nov 23 2021, 3:57 PM

Build has FAILED

Patch application report for D6673 (id=24249)

Could not rebase; Attempt merge onto 1c83b82b49...

Updating 1c83b82..e4376d4
Fast-forward
 README.md                     |  9 --------
 README.rst                    |  1 +
 docs/README.rst               | 49 +++++++++++++++++++++++++++++++++++++++++++
 docs/index.rst                |  7 +------
 setup.py                      |  4 ++--
 swh/vault/cookers/git_bare.py |  7 ++++++-
 6 files changed, 59 insertions(+), 18 deletions(-)
 delete mode 100644 README.md
 create mode 120000 README.rst
 create mode 100644 docs/README.rst
Changes applied before test
commit e4376d433f91be1625afa73dff1b7f6245fbd66f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:47:01 2021 +0100

    Add an introduction to the vault documentation

commit dd47302b5571572b8d3b4f048903c7f9f624ba24
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:22:31 2021 +0100

    git_bare: Fix counter of processed objects
    
    self._seen contains also all the objects on the todo-stacks,
    so it's incorrect to use it here.

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/193/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/193/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 23 2021, 3:57 PM
Harbormaster failed remote builds in B25126: Diff 24249!
vlorentz updated this revision to Diff 24252.Nov 23 2021, 4:05 PM

rebase + remove anchors, they make sphinx crash

vlorentz updated this revision to Diff 24254.Nov 23 2021, 4:07 PM

rebase

swh-public-ci added a comment.Nov 23 2021, 4:08 PM

Build has FAILED

Patch application report for D6673 (id=24252)

Could not rebase; Attempt merge onto 1c83b82b49...

Updating 1c83b82..ed2c662
Fast-forward
 README.md                     |  9 ---------
 README.rst                    |  1 +
 docs/README.rst               | 45 +++++++++++++++++++++++++++++++++++++++++++
 docs/index.rst                |  7 +------
 setup.py                      |  4 ++--
 swh/vault/cookers/git_bare.py | 10 +++++++++-
 6 files changed, 58 insertions(+), 18 deletions(-)
 delete mode 100644 README.md
 create mode 120000 README.rst
 create mode 100644 docs/README.rst
Changes applied before test
commit ed2c6622ffa7749a1e93dd03be457dc4b40177e7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:47:01 2021 +0100

    Add an introduction to the vault documentation

commit bee37dd84a5a85f1eb98bf768b20a09391b97c44
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:22:31 2021 +0100

    git_bare: Fix counter of processed objects
    
    self._seen contains also all the objects on the todo-stacks,
    so it's incorrect to use it here.

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/195/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/195/console

Harbormaster failed remote builds in B25129: Diff 24252!Nov 23 2021, 4:08 PM
swh-public-ci added a comment.Nov 23 2021, 4:10 PM

Build is green

Patch application report for D6673 (id=24254)

Could not rebase; Attempt merge onto 1c83b82b49...

Updating 1c83b82..35e4fd7
Fast-forward
 README.md                     |  9 ---------
 README.rst                    |  1 +
 docs/README.rst               | 45 +++++++++++++++++++++++++++++++++++++++++++
 docs/index.rst                |  7 +------
 setup.py                      |  4 ++--
 swh/vault/cookers/git_bare.py | 11 ++++++++++-
 6 files changed, 59 insertions(+), 18 deletions(-)
 delete mode 100644 README.md
 create mode 120000 README.rst
 create mode 100644 docs/README.rst
Changes applied before test
commit 35e4fd7378b7da01c307236d4b5f734367d48b9f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:47:01 2021 +0100

    Add an introduction to the vault documentation

commit 2683d573a84d67c5dc86df20ee82f2f4459c1e19
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 23 15:22:31 2021 +0100

    git_bare: Fix counter of processed objects
    
    self._seen contains also all the objects on the todo-stacks,
    so it's incorrect to use it here.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/197/ for more details.

Harbormaster completed remote builds in B25131: Diff 24254.Nov 23 2021, 4:10 PM
vlorentz requested review of this revision.Nov 23 2021, 4:10 PM
ardumont accepted this revision.Nov 23 2021, 5:41 PM
ardumont added a subscriber: ardumont.

lgtm

one typo inline.

docs/README.rst
28
setup.py
42

i think that will create problem in the debian build, we'll see ;)

This revision is now accepted and ready to land.Nov 23 2021, 5:41 PM
Closed by commit rDVAU35e4fd7378b7: Add an introduction to the vault documentation (authored by vlorentz). · Explain WhyNov 26 2021, 1:39 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDVAU35e4fd7378b7: Add an introduction to the vault documentation.
vlorentz added a task: T3605: Document the vault architecture.Nov 26 2021, 5:21 PM

Revision Contents
Changeset List

PathSize
1 line
docs/
45 lines
7 lines
4 lines

Diff 24252

View Options

README.md

Loading...
View Options

README.rst

Loading...
View Options

docs/README.rst

Loading...
View Options

docs/index.rst

Loading...
View Options

setup.py

Loading...
About · Developer information · Legal