Page MenuHomeSoftware Heritage

Revert "deposit: Remove 'parent' deposit"
ClosedPublic

Authored by vlorentz on Nov 3 2021, 3:56 PM.

Details

Summary

This reverts commit f6905cdf547c8a1325fe8b3a0cbf6cb2373031a6.

That commit was a first step toward making loaders write releases
instead of revisions.

Unfortunately, we will still write revisions for a non-negligeable time,
so I prefer to defer the removal of parent deposit revisions to the
moment we actually make that switch, so we don't end up with inconsistent
revisions.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6599 (id=23983)

Rebasing onto 9f8827935d...

Current branch diff-target is up to date.
Changes applied before test
commit 645ed666d87e850e4fd6c057d1b7488c0e31524c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 3 15:54:05 2021 +0100

    Revert "deposit: Remove 'parent' deposit"
    
    This reverts commit f6905cdf547c8a1325fe8b3a0cbf6cb2373031a6.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/588/ for more details.

Build is green

Patch application report for D6599 (id=23984)

Rebasing onto 9f8827935d...

Current branch diff-target is up to date.
Changes applied before test
commit 5063082e7dc176939e2f952b83f10cf0b1f0aabc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 3 15:54:05 2021 +0100

    Revert "deposit: Remove 'parent' deposit"
    
    This reverts commit f6905cdf547c8a1325fe8b3a0cbf6cb2373031a6.
    
    That commit was a first step toward making loaders write releases
    instead of revisions.
    
    Unfortunately, we will still write revisions for a non-negligeable time,
    so I prefer to defer the removal of parent deposit revisions to the
    moment we actually make that switch, so we don't end up with inconsistent
    revisions.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/589/ for more details.

This revision is now accepted and ready to land.Nov 3 2021, 4:01 PM