Page MenuHomeSoftware Heritage

assets/save: Fix sourceforge git repository URL validation
ClosedPublic

Authored by anlambert on Oct 26 2021, 11:30 AM.

Details

Summary

The assumption that URL paths to git repos for the git.code.sf.net
netloc are necessarily prefixed by /p/ is wrong.

Related to T3690

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24693
Build 38539: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 38538: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6551 (id=23810)

Rebasing onto eb1d40198a...

Current branch diff-target is up to date.
Changes applied before test
commit 2f5d8cc1fbd3cb05825e37811c1951b5b6c24c77
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 26 11:28:28 2021 +0200

    assets/save: Fix sourceforge git repository URL validation
    
    The assumption that URL paths to git repos for the git.code.sf.net
    netloc are necessarily prefixed by /p/ is wrong.
    
    Related to T3690

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1211/ for more details.

This revision is now accepted and ready to land.Oct 26 2021, 12:16 PM