Page MenuHomeSoftware Heritage
Differential D6274

Upgrade hedgedoc to 1.9.0
ClosedPublic
Actions

Authored by olasd on Sep 15 2021, 5:24 PM.

Details

Reviewers
vsellier
ardumont
Maniphest Tasks
T3574: Upgrade hedgedoc to 1.9.0
Commits
rSPSITEfe519c3939cd: Upgrade hedgedoc to 1.9.0
rSPSITEf5110a49138e: Add apt source configuration for nodejs LTS 14.x
rSPSITE28c7f765463a: Update expired yarn public key
Summary

Needs the following changes as well:

  • Update expired yarn public key
  • Add apt source configuration for nodejs LTS 14.x

Related to T3574

Test Plan

tested the (unattended) upgrade procedure in vagrant

Diff Detail

Repository
rSPSITE puppet-swh-site
Branch
hedgedoc-1.9.0
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23891
Build 37256: arc lint + arc unit

Event Timeline

olasd requested review of this revision.Sep 15 2021, 5:24 PM
olasd created this revision.
Harbormaster completed remote builds in B23652: Diff 22719.Sep 15 2021, 5:24 PM
ardumont added inline comments.Sep 15 2021, 6:31 PM
site-modules/profile/templates/hedgedoc/hedgedoc.service.erb
2–5

lol, i see some people knows how to stay humble ;)

41

Where does this variable come from?
I don't see them in the manifest calling this template.

ardumont added a comment.Sep 15 2021, 6:37 PM

One question inline.

Also, I'm not completely sure what entails the change from present to latest for the
node stack packages...

Otherwise, that looks rather good to me.

Thanks

olasd added inline comments.Sep 16 2021, 9:49 AM
site-modules/profile/templates/hedgedoc/hedgedoc.service.erb
41

It comes from the manifest calling this template (profile::hedgedoc, line 20).

olasd added a comment.Sep 16 2021, 9:50 AM
In D6274#162385, @ardumont wrote:

Also, I'm not completely sure what entails the change from present to latest for the
node stack packages...

The node package needs an update for hedgedoc 1.9.0 to work.

ardumont added a comment.Sep 16 2021, 10:20 AM

Also, I'm not completely sure what entails the change from present to latest for the
node stack packages...

The node package needs an update for hedgedoc 1.9.0 to work.

yes, i understood that but i meant the other packages in the array.
Well, if there is no risk then moving along.

ardumont accepted this revision.Sep 16 2021, 10:21 AM
ardumont added inline comments.
site-modules/profile/templates/hedgedoc/hedgedoc.service.erb
41

oops, yeah, sorry, i expected it to show up in the diff somehow.
Thanks.

This revision is now accepted and ready to land.Sep 16 2021, 10:21 AM
olasd updated this revision to Diff 22961.Sep 22 2021, 12:46 PM

rebase

Harbormaster completed remote builds in B23891: Diff 22961.Sep 22 2021, 12:46 PM
Closed by commit rSPSITE28c7f765463a: Update expired yarn public key (authored by olasd). · Explain WhySep 22 2021, 12:47 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rSPSITE28c7f765463a: Update expired yarn public key.
olasd added a commit: rSPSITEf5110a49138e: Add apt source configuration for nodejs LTS 14.x.
olasd added a commit: rSPSITEfe519c3939cd: Upgrade hedgedoc to 1.9.0.

Revision Contents
Changeset List

PathSize
data/
common/
2 lines
196 lines
hostname/
4 lines
site-modules/
profile/
manifests/
hedgedoc/
11 lines
nodejs/
16 lines
templates/
hedgedoc/
3 lines
46 lines

Diff 22961

View Options

data/common/common.yaml

Loading...
View Options

data/common/public_keys.yaml

Loading...
View Options

data/hostname/bardo.internal.admin.swh.network.yaml

Loading...
View Options

site-modules/profile/manifests/hedgedoc/apt_config.pp

Loading...
View Options

site-modules/profile/manifests/nodejs/apt_config.pp

Loading...
View Options

site-modules/profile/templates/hedgedoc/config.json.erb

Loading...
View Options

site-modules/profile/templates/hedgedoc/hedgedoc.service.erb

Loading...
About · Developer information · Legal