Depends on D6295.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDLDCVSfb5a1a8ac518: Simplify exception handling.
Diff Detail
Diff Detail
- Repository
- rDLDCVS CVS Loader
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23870 Build 37225: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 37224: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6297 (id=22874)
Could not rebase; Attempt merge onto dd8a625ca0...
Auto-merging swh/loader/cvs/loader.py Merge made by the 'recursive' strategy. .gitignore | 1 + swh/loader/cvs/loader.py | 88 ++++++++++++++++++------------------- swh/loader/cvs/tests/test_loader.py | 3 ++ 3 files changed, 48 insertions(+), 44 deletions(-)
Changes applied before test
commit a8a465f45640e4f4a51f4d48fa7dd72d0dbcd710 Merge: dd8a625 4d5e5d2 Author: Jenkins user <jenkins@localhost> Date: Fri Sep 17 14:37:17 2021 +0000 Merge branch 'diff-target' into HEAD commit 4d5e5d25d9f7794e223fac11965343768b53e5fa Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Sep 17 16:36:37 2021 +0200 Simplify exception handling. commit 051dec1fe0c0252cb569ecf763b49210280cfe7f Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Sep 17 16:36:07 2021 +0200 Ignore generated .so files They are in this location when installing in development mode. commit af3755766012b58ddf5713fb2e0504033c9de903 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Sep 17 16:34:37 2021 +0200 Use lazy substitution for logging + fix error messages eg. self.log.exception already include the exception (and its traceback), so it does not need to be part of the message. commit b7e97029636648ddb53ad7bed8623e97a546e445 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Sep 17 16:28:52 2021 +0200 load_status should not be 'uneventful' if the snapshot changed Even if the revision was already loaded; it might have been for a different origin.
See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/18/ for more details.
Comment Actions
Build is green
Patch application report for D6297 (id=22940)
Rebasing onto a6e9882352...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-25-D6297.
Changes applied before test
See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/25/ for more details.