Differential D719

Split test utilities off BaseLoaderTest.
ClosedPublic
Actions

Authored by vlorentz on Nov 27 2018, 6:38 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASEe20fc69f654c: Split test utilities off BaseLoaderTest.

Summary

So loader tests that handle the archive themselves (eg. swh.deposit)
can use them.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

BaseLoaderStorageTest

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 2648
Build 3294: tox-on-jenkins	Jenkins
Build 3293: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 27 2018, 6:38 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 27 2018, 6:38 PM

Remove assertOriginMetadataOk, it does not belong in that diff.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/25/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/25/console

Harbormaster failed remote builds in B2647: Diff 2273!Nov 27 2018, 6:40 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/26/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/26/console

Harbormaster failed remote builds in B2648: Diff 2274!Nov 27 2018, 6:42 PM

vlorentz added a child revision: D721: Remove Storage mock..Nov 27 2018, 6:51 PM

Sounds reasonable.

This revision is now accepted and ready to land.Nov 28 2018, 12:06 PM

Closed by commit rDLDBASEe20fc69f654c: Split test utilities off BaseLoaderTest. (authored by vlorentz). · Explain WhyNov 28 2018, 12:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

loader/

core/

tests/

__init__.py

131 lines

Diff 2274

View Options

swh/loader/core/tests/init.py

Split test utilities off BaseLoaderTest.ClosedPublicActions