Page MenuHomeSoftware Heritage

templates/content-display: Remove script tag when no content to display
ClosedPublic

Authored by anlambert on Aug 27 2021, 4:17 PM.

Details

Summary

When a content cannot be displayed (for instance due to a too large size),
remove script tag from template to prevent execution errors.

Closes T3454

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23257
Build 36291: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 36290: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6155 (id=22283)

Rebasing onto 3a448d88c8...

Current branch diff-target is up to date.
Changes applied before test
commit b8c2933c97a35067be5b44230927cb00c6f3d290
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Aug 27 16:14:13 2021 +0200

    templates/content-display: Remove script tag when no content to display
    
    When a content cannot be displayed (for instance due to a too large size),
    remove script tag from template to prevent execution errors.
    
    Closes T3454

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1040/ for more details.

This revision is now accepted and ready to land.Aug 30 2021, 10:41 AM

Build is green

Patch application report for D6155 (id=22301)

Rebasing onto 9f358af9a4...

Current branch diff-target is up to date.
Changes applied before test
commit f15e17c406c01972efe784641be225c435d0ed44
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Aug 27 16:14:13 2021 +0200

    templates/content-display: Remove script tag when no content to display
    
    When a content cannot be displayed (for instance due to a too large size),
    remove script tag from template to prevent execution errors.
    
    Closes T3454

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1042/ for more details.