Page MenuHomeSoftware Heritage

identify: Fix exclude_patterns parameter type for identify_object
ClosedPublic

Authored by anlambert on Jun 16 2021, 12:15 PM.

Details

Summary

Since rDMODe09446a6f44b9070ea70a9760bc82dee0bbcb687, it must be an
iterable of bytes.

Issue spotted thanks to the swh-environment build on Jenkins and the
new failing tests.

Diff Detail

Repository
rDLDHG Mercurial loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22055
Build 34304: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 34303: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5879 (id=21063)

Rebasing onto 2877eb3c4e...

Current branch diff-target is up to date.
Changes applied before test
commit 86a0689f8116a51a9e0fd093e06577af8a6ec1c6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jun 16 12:11:10 2021 +0200

    identify: Fix exclude_patterns parameter type for identify_object
    
    Since rDMODe09446a6f44b9070ea70a9760bc82dee0bbcb687, it must be an
    iterable of bytes.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/256/ for more details.

I think this also needs bumping the versioned dependency on swh-model (and a release of that).

In D5879#150207, @zack wrote:

I think this also needs bumping the versioned dependency on swh-model (and a release of that).

already done ;-)

In D5879#150207, @zack wrote:

I think this also needs bumping the versioned dependency on swh-model (and a release of that).

already done ;-)

remain dep bumping though, will update

Build is green

Patch application report for D5879 (id=21064)

Rebasing onto 2877eb3c4e...

Current branch diff-target is up to date.
Changes applied before test
commit f3232bfd67869c1acd66bbb871139908cc8dd910
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jun 16 12:11:10 2021 +0200

    identify: Fix exclude_patterns parameter type for identify_object
    
    Since rDMODe09446a6f44b9070ea70a9760bc82dee0bbcb687, it must be an
    iterable of bytes.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/257/ for more details.

This revision is now accepted and ready to land.Jun 16 2021, 12:35 PM