It's needed by the ci to be able to reference the api links
Related to T3307
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Maniphest Tasks
- T3307: apidoc generation is not performed on swh modules during dev build
- Commits
- rDDOC5e6f5d854803: Don't install the modules in editable mode
Diff Detail
Diff Detail
- Repository
- rDDOC Development documentation
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21281 Build 33045: arc lint + arc unit
Event Timeline
Comment Actions
If I recall correctly, without using the -e option of pip, some swh packages end up installed from pypi by dependencies transitivity.
For the sphinx-dev tox target, we want to use the local state of each swh package so the use of -e to force that fact.
So not sure that's the best solution here.
Comment Actions
@vsellier, in fact I got mistaken by the sphinx warning below that I thought having fixed but it is still there:
/home/anlambert/swh/swh-environment/swh-docs/docs/swh-core/cli.rst:3: WARNING: Definition list ends without a blank line; unexpected unindent.
I thought using -e option will use package state after the last tag but it is already the case when you install a package from its local path.
So you are right, the solution is to remove the -e option of pip.
| Makefile.local | ||
|---|---|---|
| -1–5 | You can remove this and simply remove the -e option of pip. | |
| Makefile.local | ||
|---|---|---|
| -1–5 | great, I thought it was useful for local runs | |
| Makefile.local | ||
|---|---|---|
| -1–5 | I believe @anlambert meant this: ifeq ($(PIP_INSTALL_EDITABLE),yes) PIP_INSTALL_OPTIONS="-e" endif But I'd rather keep it explicit | |
| Makefile.local | ||
|---|---|---|
| -1–5 | Nope, we can simply drop the use of -e. It was a mistake of mine. | |
Comment Actions
And I think that I found how to fix the last remaining warning cited above.
good news ;)
thanks