Page MenuHomeSoftware Heritage

Move parse_swh_reference to swh.deposit.utils namespace
ClosedPublic

Authored by ardumont on Dec 14 2020, 5:35 PM.

Details

Summary

So it can be reused in other non django part of the deposit (e.g
deposit client cli)

Related to T2886

Test Plan

tox

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17934
Build 27707: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 27706: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D4735 (id=16772)

Rebasing onto 73ee587df9...

Current branch diff-target is up to date.
Changes applied before test
commit 36527db3c35089f11b56858df8de6fc3a221f6e3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Dec 14 17:34:22 2020 +0100

    Move parse_swh_reference in swh.deposit.utils namespace
    
    So it can be reused in other non django part of the deposit.
    
    Related to T2886

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/479/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/479/console

swh/deposit/tests/cli/test_client.py
642 ↗(On Diff #16772)

oops, not meant here ¯\_(ツ)_/¯, this is what fails the build...

Drop test code not meant for that diff

zack retitled this revision from Move parse_swh_reference in swh.deposit.utils namespace to Move parse_swh_reference to swh.deposit.utils namespace.Dec 14 2020, 5:46 PM

Build is green

Patch application report for D4735 (id=16774)

Rebasing onto 73ee587df9...

Current branch diff-target is up to date.
Changes applied before test
commit 2e0c77b59f4ef11fc6385465caf4f0dd48485309
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Dec 14 17:43:36 2020 +0100

    Move parse_swh_reference in swh.deposit.utils namespace
    
    So it can be reused in other non django part of the deposit.
    
    Related to T2886

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/480/ for more details.

Build is green

Patch application report for D4735 (id=16775)

Rebasing onto 73ee587df9...

Current branch diff-target is up to date.
Changes applied before test
commit 36f0b632966bf94ff2d4b9880e1ca89c6b14a68e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Dec 14 17:43:36 2020 +0100

    Move parse_swh_reference to swh.deposit.utils namespace
    
    So it can be reused in other non django part of the deposit.
    
    Related to T2886

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/481/ for more details.

This revision is now accepted and ready to land.Dec 15 2020, 10:02 AM