Page MenuHomeSoftware Heritage
Differential D4499

Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.
ClosedPublic
Actions

Authored by vlorentz on Nov 18 2020, 11:10 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDDEP329a2a3785ad: Rename files and classes in swh/deposit/api/deposit_* to be consistent with…

Diff Detail

Unit TestsFailed
View All

TimeTest
546 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.collection.test_collection::test_act_on_deposit_rejected_is_not_permitted
datadir = '/var/lib/jenkins/workspace/DDEP/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/deposit/tests/api/collection/../data' @pytest.fixture
536 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.collection.test_collection::test_add_deposit_when_done_makes_new_deposit_with_parent_old_one
datadir = '/var/lib/jenkins/workspace/DDEP/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/deposit/tests/api/collection/../data' @pytest.fixture
537 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.collection.test_collection::test_add_deposit_when_failed_makes_new_deposit_with_no_parent
datadir = '/var/lib/jenkins/workspace/DDEP/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/deposit/tests/api/collection/../data' @pytest.fixture
529 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.collection.test_collection::test_add_deposit_when_partial_makes_new_deposit
datadir = '/var/lib/jenkins/workspace/DDEP/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/deposit/tests/api/collection/../data' @pytest.fixture
467 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.collection.test_multipart::test_post_deposit_multipart_400_when_badly_formatted_xml
datadir = '/var/lib/jenkins/workspace/DDEP/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/deposit/tests/api/collection/../data' @pytest.fixture
View Full Test Results (34 Failed · 175 Passed)

Event Timeline

vlorentz created this revision.Nov 18 2020, 11:10 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 18 2020, 11:10 AM
swh-public-ci added a comment.Nov 18 2020, 11:13 AM

Build is green

Patch application report for D4499 (id=15959)

Rebasing onto c1a45162d3...

Current branch diff-target is up to date.
Changes applied before test
commit 2cc3f33a7f284deb251c73740637acf290a4a902
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 11:10:49 2020 +0100

    Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/355/ for more details.

Harbormaster completed remote builds in B17164: Diff 15959.Nov 18 2020, 11:13 AM
ardumont requested changes to this revision.EditedNov 18 2020, 11:30 AM
ardumont added a subscriber: ardumont.

Please update the test files as well.
(That also needs a rebase).

This revision now requires changes to proceed.Nov 18 2020, 11:30 AM
vlorentz updated this revision to Diff 15964.Nov 18 2020, 12:12 PM

rebase + rename test files.

vlorentz added a child revision: D4500: remove assumption that Edit-IRI and SE-IRI are the same from test_post_deposit_atom_entry_multiple_steps..Nov 18 2020, 12:13 PM
swh-public-ci added a comment.Nov 18 2020, 12:15 PM

Build has FAILED

Patch application report for D4499 (id=15964)

Rebasing onto a67ed6b06b...

Current branch diff-target is up to date.
Changes applied before test
commit d7f5a6f60ecff310675775c58be34a87d9b691a5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 11:10:49 2020 +0100

    Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/356/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/356/console

Harbormaster failed remote builds in B17169: Diff 15964!Nov 18 2020, 12:15 PM
vlorentz updated this revision to Diff 15969.Nov 18 2020, 12:19 PM

meh, I can't use a subdir for the tests

swh-public-ci added a comment.Nov 18 2020, 12:24 PM

Build is green

Patch application report for D4499 (id=15969)

Rebasing onto a67ed6b06b...

Current branch diff-target is up to date.
Changes applied before test
commit 329a2a3785ad8431fa7ec73fee31e86dbee36911
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 11:10:49 2020 +0100

    Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/359/ for more details.

Harbormaster completed remote builds in B17174: Diff 15969.Nov 18 2020, 12:24 PM
ardumont accepted this revision.Nov 18 2020, 2:30 PM

I'll assume it's fine.

I'm completely dusty on the sword v2 terms now.

This revision is now accepted and ready to land.Nov 18 2020, 2:30 PM
vlorentz added a comment.Nov 18 2020, 3:17 PM
In D4499#112546, @ardumont wrote:

I'll assume it's fine.

I'm completely dusty on the sword v2 terms now.

just check names match the docstrings you wrote ;)

ardumont added a comment.Nov 18 2020, 3:41 PM

I'll assume it's fine.

I'm completely dusty on the sword v2 terms now.

just check names match the docstrings you wrote ;)

yes, that's what i did ;)

Closed by commit rDDEP329a2a3785ad: Rename files and classes in swh/deposit/api/deposit_* to be consistent with… (authored by vlorentz). · Explain WhyNov 18 2020, 4:09 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEP329a2a3785ad: Rename files and classes in swh/deposit/api/deposit_* to be consistent with….

Revision Contents
Changeset List

PathSize
swh/
deposit/
api/
collection.py
deposit.py
4 lines
content.py
deposit_content.py
10 lines
edit.py
deposit_update.py
93 lines
87 lines
2 lines
state.py
deposit_status.py
4 lines
31 lines
tests/
api/
collection/
collection/
test_collection.py
test_deposit.py
194 lines
test_multipart.py
test_deposit_multipart.py
2 lines
test_post_atom.py
test_deposit_atom.py
2 lines
test_post_binary.py
test_deposit_binary.py
2 lines
test_post_metadata.py
test_deposit_metadata.py
2 lines
test_delete.py
test_deposit_delete.py
131 lines
test_get_file.py
test_deposit_content.py
2 lines

Diff 15964

View Options

swh/deposit/api/collection.py

Loading...
View Options

swh/deposit/api/content.py

Loading...
View Options

swh/deposit/api/deposit.py

Loading...
View Options

swh/deposit/api/deposit_content.py

Loading...
View Options

swh/deposit/api/deposit_status.py

Loading...
View Options

swh/deposit/api/deposit_update.py

Loading...
View Options

swh/deposit/api/edit.py

Loading...
View Options

swh/deposit/api/edit_media.py

Loading...
View Options

swh/deposit/api/service_document.py

Loading...
View Options

swh/deposit/api/state.py

Loading...
View Options

swh/deposit/api/urls.py

Loading...
View Options

swh/deposit/tests/api/collection/__init__.py

Loading...
View Options

swh/deposit/tests/api/collection/test_collection.py

Loading...
View Options

swh/deposit/tests/api/collection/test_multipart.py

Loading...
View Options

swh/deposit/tests/api/collection/test_post_atom.py

Loading...
View Options

swh/deposit/tests/api/collection/test_post_binary.py

Loading...
View Options

swh/deposit/tests/api/collection/test_post_metadata.py

Loading...
View Options

swh/deposit/tests/api/test_delete.py

Loading...
View Options

swh/deposit/tests/api/test_deposit.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_atom.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_binary.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_content.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_delete.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_metadata.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_multipart.py

Loading...
View Options

swh/deposit/tests/api/test_get_file.py

Loading...
About · Developer information · Legal