Differential D469

loader.tar.tests: Refactor using loader-core mixins
ClosedPublic
Actions

Authored by ardumont on Oct 3 2018, 5:59 PM.

Tags

None

Subscribers

Details

Reviewers

anlambert
olasd
vlorentz

Group Reviewers

Commits

rDLDTAR4ec92e59d7bf: tar.tests: Do not leak core loader fixture's state
rDLDTARd901f6027e68: loader.tests: Refactor using loader-core mixin
rDLDTAR35fa3a1ec324: .gitignore: Ignore .eggs

Summary

Related T1238
Depends on D467

Test Plan

make test

Diff Detail

Repository

rDLDTAR Tarball Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 3 2018, 5:59 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 3 2018, 5:59 PM

Harbormaster completed remote builds in B1497: Diff 1433.Oct 3 2018, 5:59 PM

ardumont retitled this revision from .gitignore: Ignore .eggs to loader.tests: Refactor using loader-core mixin.Oct 3 2018, 6:00 PM

ardumont edited the summary of this revision. (Show Details)

ardumont edited the test plan for this revision. (Show Details)

ardumont added a parent revision: D467: loader.core.tests: Add loader core fixtures to ease loaders' tests.

ardumont retitled this revision from loader.tests: Refactor using loader-core mixin to loader.tests: Refactor using loader-core mixins.Oct 3 2018, 11:24 PM

ardumont added reviewers: anlambert, olasd.Oct 3 2018, 11:26 PM

ardumont added a subscriber: douardda.

ardumont retitled this revision from loader.tests: Refactor using loader-core mixins to loader.tar.tests: Refactor using loader-core mixins.Oct 8 2018, 1:58 PM

.gitignore: Ignore .eggs
loader.tests: Refactor using loader-core mixin
tar.tests: Do not leak core loader fixture's state

+ Rebase

Harbormaster completed remote builds in B1591: Diff 1554.Oct 9 2018, 12:21 PM

vlorentz accepted this revision.Oct 9 2018, 1:14 PM

This revision is now accepted and ready to land.Oct 9 2018, 1:14 PM

Closed by commit rDLDTAR35fa3a1ec324: .gitignore: Ignore .eggs (authored by ardumont). · Explain WhyOct 9 2018, 2:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

1 line

Diff 1562

.gitignore

Loading...