backfill: support arbitrary journal writer configuration
ClosedPublic
Actions

Authored by olasd on Oct 8 2020, 8:59 PM.

Details

Reviewers

douardda

Commits

rDSTOdceeb7443c7f: backfill: support arbitrary journal writer configuration

Summary

This allows more settings than the previous hardcoded three, e.g. the
privileged flag to backfill a journal containing anonymous topics.

Test Plan

tox tests updated

Diff Detail

Repository

rDSTO Storage manager

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16081
Build 24735: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24734: arc lint + arc unit

Event Timeline

olasd created this revision.Oct 8 2020, 8:59 PM

olasd added a child revision: D4210: backfill: use the common `storage` top-level config key.

Build is green

Patch application report for D4209 (id=14843)

Rebasing onto a6af589ada...

Current branch diff-target is up to date.

Changes applied before test

commit dceeb7443c7fc8361586ffdccadb10cdfc10a9a1
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Oct 8 18:32:35 2020 +0200

    backfill: support arbitrary journal writer configuration
    
    This allows more settings than the previous hardcoded three, e.g. the
    `privileged` flag to backfill a journal containing anonymous topics.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1001/ for more details.

Harbormaster completed remote builds in B16081: Diff 14843.Oct 8 2020, 9:03 PM

oh so much yes!

This revision is now accepted and ready to land.Oct 9 2020, 4:33 PM

Closed by commit rDSTOdceeb7443c7f: backfill: support arbitrary journal writer configuration (authored by olasd). · Explain WhyOct 9 2020, 4:35 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTOdceeb7443c7f: backfill: support arbitrary journal writer configuration.