Page MenuHomeSoftware Heritage

deposit: public api: Rename appropriately classes with meaningful names
ClosedPublic

Authored by ardumont on Sep 11 2020, 4:06 PM.

Details

Summary

There are lots of classes with names like "SWH" or even "Deposit", those are
redundant with the current swh repository about the deposit.

I'd like to clean up a bit prior to actually getting back in that code for the
metadata deposit update.

Test Plan

tox

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15073
Build 23234: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23233: arc lint + arc unit

Event Timeline

ardumont retitled this revision from deposit: Rename appropriately classes with meaningfull names to deposit: Rename appropriately classes with meaningful names.Sep 11 2020, 4:07 PM

Build is green

Patch application report for D3929 (id=13846)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit d467e2596a9f3803f2673c8f291a906e8041367a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningfull names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/69/ for more details.

  • Rename SWHBaseDeposit to APIBase

Build is green

Patch application report for D3929 (id=13847)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit aa0efd36b8d5453445233c2bee10024f603e726f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/70/ for more details.

  • Rename SWHGetDepositAPI to GetAPI
  • Rename SWHPostDepositAPI to PostAPI

Build is green

Patch application report for D3929 (id=13848)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit ca0db1cd59c6530c4663d8a7605c9e67ff6a1ad8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:17:08 2020 +0200

    Rename SWHBaseDeposit to APIBase

commit aa0efd36b8d5453445233c2bee10024f603e726f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/71/ for more details.

  • Rename SWHPutDepositAPI to PutAPI

Build is green

Patch application report for D3929 (id=13850)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit 3a9f40af5173eeb56397ea5d52ebe079c66509a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:18:56 2020 +0200

    Rename SWHGetDepositAPI to GetAPI

commit ca0db1cd59c6530c4663d8a7605c9e67ff6a1ad8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:17:08 2020 +0200

    Rename SWHBaseDeposit to APIBase

commit aa0efd36b8d5453445233c2bee10024f603e726f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/72/ for more details.

Build is green

Patch application report for D3929 (id=13851)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit b7c1d6b727dd466dae793ffaf57387e34739ae85
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:21:07 2020 +0200

    Rename SWHPostDepositAPI to PostAPI

commit 3a9f40af5173eeb56397ea5d52ebe079c66509a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:18:56 2020 +0200

    Rename SWHGetDepositAPI to GetAPI

commit ca0db1cd59c6530c4663d8a7605c9e67ff6a1ad8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:17:08 2020 +0200

    Rename SWHBaseDeposit to APIBase

commit aa0efd36b8d5453445233c2bee10024f603e726f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/73/ for more details.

Build is green

Patch application report for D3929 (id=13852)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit fe0ac32e6cbeba1ea09ba7f7f8780da970ae5259
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:23:04 2020 +0200

    Rename SWHDeleteDepositAPI to DeleteAPI

commit 81d0e09c93abcfa6d331fb8c2c058d3e08360caa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:22:08 2020 +0200

    Rename SWHPutDepositAPI to PutAPI

commit b7c1d6b727dd466dae793ffaf57387e34739ae85
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:21:07 2020 +0200

    Rename SWHPostDepositAPI to PostAPI

commit 3a9f40af5173eeb56397ea5d52ebe079c66509a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:18:56 2020 +0200

    Rename SWHGetDepositAPI to GetAPI

commit ca0db1cd59c6530c4663d8a7605c9e67ff6a1ad8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:17:08 2020 +0200

    Rename SWHBaseDeposit to APIBase

commit aa0efd36b8d5453445233c2bee10024f603e726f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/74/ for more details.

This revision is now accepted and ready to land.Sep 11 2020, 4:39 PM

Refactor and unify names so classes start with API...
(also squash commits)

Build is green

Patch application report for D3929 (id=13858)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit ac7e8cbb6a905b0574ee67c9084f178aec0ae380
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/75/ for more details.

Forgot to rename to APIGet...

ardumont retitled this revision from deposit: Rename appropriately classes with meaningful names to deposit: public api: Rename appropriately classes with meaningful names.Sep 11 2020, 5:45 PM
ardumont edited the summary of this revision. (Show Details)

Build is green

Patch application report for D3929 (id=13860)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit cb4b60022d318dfd8803e43c416a2a8ea788ee96
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    public api: Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH or Deposit terms along the way.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/76/ for more details.