Differential D3727

model: Add final object_type field on metadata related model objects
ClosedPublic
Actions

Authored by ardumont on Aug 6 2020, 7:03 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDMOD09dcc04a4c38: model: Add final object_type field on metadata related model objects

Summary

To avoid inconsistencies with our other object models

This also fixes current storage build failure

[1] https://forge.softwareheritage.org/harbormaster/unit/view/744333/

[2] https://jenkins.softwareheritage.org/job/DSTO/job/tests/1530/console

@vlorentz didn't you open one diff about this (I don't find it)?

Test Plan

tox

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14395
Build 22127: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22126: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 6 2020, 7:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 6 2020, 7:03 PM

Build is green

Patch application report for D3727 (id=13129)

Rebasing onto 37cdd84911...

Current branch diff-target is up to date.

Changes applied before test

commit 09dcc04a4c38b8d3f46ece7028d5a7fc4293eb99
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 19:00:21 2020 +0200

    model: Add final object_type field on metadata related model objects

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/127/ for more details.

Harbormaster completed remote builds in B14395: Diff 13129.Aug 6 2020, 7:04 PM

ardumont mentioned this in D3723: cassandra.storage: Use next token for pagination instead of computing it.Aug 6 2020, 7:08 PM

ardumont edited the summary of this revision. (Show Details)Aug 6 2020, 7:10 PM

WTF? I already did that??

Oh damn... I tagged it as v0.6.1 (and pushed the tag), but forgot to push to master.........

This revision is now accepted and ready to land.Aug 6 2020, 7:13 PM

D3653

Closed by commit rDMOD09dcc04a4c38: model: Add final object_type field on metadata related model objects (authored by ardumont). · Explain WhyAug 6 2020, 7:58 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDMOD09dcc04a4c38: model: Add final object_type field on metadata related model objects.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

model/

model.py

6 lines

97%

Diff 13129

View Options

model: Add final object_type field on metadata related model objectsClosedPublicActions