Page MenuHomeSoftware Heritage
Differential D3700

storage*: content_get: Type remaining existing endpoints
ClosedPublic
Actions

Authored by ardumont on Aug 4 2020, 6:40 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2517: Add remaining missing types to swh.storage.interface
Commits
rDSTOc6da28289ec4: storage*: content_get: Type remaining existing endpoints
Summary

Related to T645

Test Plan

tox

Diff Detail

Event Timeline

ardumont created this revision.Aug 4 2020, 6:40 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2020, 6:40 PM
ardumont updated this revision to Diff 13033.Aug 4 2020, 6:45 PM

Fix docstring according to reality (storage argument exception)

ardumont added inline comments.Aug 4 2020, 6:46 PM
swh/storage/interface.py
159

sneaky devil!

swh-public-ci added a comment.Aug 4 2020, 6:53 PM

Build has FAILED

Patch application report for D3700 (id=13032)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..ef6186c8
Fast-forward
 swh/storage/cassandra/storage.py | 27 ++++++++++++++++-----------
 swh/storage/in_memory.py         | 25 +++++++++++++++----------
 swh/storage/interface.py         | 36 ++++++++++++++++++++----------------
 swh/storage/storage.py           | 24 +++++++++++++++---------
 4 files changed, 66 insertions(+), 46 deletions(-)
Changes applied before test
commit ef6186c89ed579b344c0c77982a17b52dadf299e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 2925f7176a0f6ede8242c6507a69a00ce313cca2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/669/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/669/console

Harbormaster failed remote builds in B14275: Diff 13032!Aug 4 2020, 6:53 PM
swh-public-ci added a comment.Aug 4 2020, 6:57 PM

Build has FAILED

Patch application report for D3700 (id=13033)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..6d15e4d4
Fast-forward
 swh/storage/cassandra/storage.py | 27 ++++++++++++++++-----------
 swh/storage/in_memory.py         | 25 +++++++++++++++----------
 swh/storage/interface.py         | 40 +++++++++++++++++++++++-----------------
 swh/storage/storage.py           | 24 +++++++++++++++---------
 4 files changed, 69 insertions(+), 47 deletions(-)
Changes applied before test
commit 6d15e4d4c2544c36dac8eb6d12cbc17cdf401e10
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 2925f7176a0f6ede8242c6507a69a00ce313cca2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/670/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/670/console

Harbormaster failed remote builds in B14276: Diff 13033!Aug 4 2020, 6:57 PM
ardumont updated this revision to Diff 13041.Aug 4 2020, 9:46 PM

Rebase

swh-public-ci added a comment.Aug 4 2020, 10:00 PM

Build is green

Patch application report for D3700 (id=13041)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..c6da2828
Fast-forward
 swh/storage/cassandra/storage.py | 27 ++++++++++++++++-----------
 swh/storage/in_memory.py         | 27 +++++++++++++++++----------
 swh/storage/interface.py         | 40 +++++++++++++++++++++++-----------------
 swh/storage/storage.py           | 24 +++++++++++++++---------
 4 files changed, 71 insertions(+), 47 deletions(-)
Changes applied before test
commit c6da28289ec4f1be1eb1c1e78d561b8cc8dac937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 25ebc48198d665cc3bb71c96a8ae54775ddf38a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/678/ for more details.

Harbormaster completed remote builds in B14284: Diff 13041.Aug 4 2020, 10:00 PM
vlorentz accepted this revision.Aug 5 2020, 8:56 AM
vlorentz added a subscriber: vlorentz.

FYI, renaming from content to contents will break the RPC, so you'll have to update clients and server at the same time.

swh/storage/interface.py
170

s/Streams of//

This revision is now accepted and ready to land.Aug 5 2020, 8:56 AM
Closed by commit rDSTOc6da28289ec4: storage*: content_get: Type remaining existing endpoints (authored by ardumont). · Explain WhyAug 5 2020, 11:31 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDSTOc6da28289ec4: storage*: content_get: Type remaining existing endpoints.
ardumont added a task: T2517: Add remaining missing types to swh.storage.interface.Aug 5 2020, 1:12 PM
ardumont removed a task: T645: Type swh-storage endpoints with swh.model objects.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
storage/
cassandra/
11 lines95%
Loading...
10 lines98%
Loading...
20 lines67%
Loading...
10 lines94%
Loading...

Diff 13041

View Options

swh/storage/cassandra/storage.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/interface.py

Loading...
View Options

swh/storage/storage.py

Loading...
About · Developer information · Legal