Differential D3704

storage*: content_missing_per_sha1(_git): Type remaining existing endpoints
ClosedPublic
Actions

Authored by ardumont on Aug 4 2020, 6:58 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2517: Add remaining missing types to swh.storage.interface

Commits

rDSTO1a2aa70c687c: storage*: content_missing_per_sha1_git: Type remaining existing endpoints
rDSTO15e48633a6a7: storage*: content_missing_per_sha1: Type remaining existing endpoints

Summary

(2 commits within the diff)

Related to T645

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14281
Build 21963: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21962: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 4 2020, 6:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2020, 6:58 PM

Build was aborted

Patch application report for D3704 (id=13037)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..d2a77879
Fast-forward
 swh/storage/cassandra/storage.py | 52 ++++++++++++++---------
 swh/storage/in_memory.py         | 58 ++++++++++++++++---------
 swh/storage/interface.py         | 91 ++++++++++++++++++++++------------------
 swh/storage/storage.py           | 58 +++++++++++++++----------
 4 files changed, 156 insertions(+), 103 deletions(-)

Changes applied before test

commit d2a778794c1f8ae8fba64bfe734a4ccddde6bce6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:57:37 2020 +0200

    storage*: content_missing_per_sha1_git: Type remaining existing endpoints
    
    Related to T645

commit 38b3681e1280f503664a59952d0c7e5b21d99526
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:55:39 2020 +0200

    storage*: content_missing_per_sha1: Type remaining existing endpoints
    
    Related to T645

commit b62afbbbdd95aaa91163c8907fa7237231d7c3a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:13:43 2020 +0200

    storage*: content_missing: Unify and type remaining existing endpoints
    
    This updates the docstrings as well
    
    Related to T645

commit d6f26e45e9a62894ab2b888a15f8a4417c3b2ce0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:06:06 2020 +0200

    storage*: content_get_partition: Type remaining existing endpoints
    
    Related to T645

commit 864473370acdfd5acaf9afbfea9d16745b3c102f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:56:39 2020 +0200

    storage*: content_get_range: Type remaining existing endpoints
    
    Related to T645

commit c6da28289ec4f1be1eb1c1e78d561b8cc8dac937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 25ebc48198d665cc3bb71c96a8ae54775ddf38a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/674/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/674/console

Harbormaster failed remote builds in B14280: Diff 13037!Aug 4 2020, 7:31 PM

fixes mistypes

storage*: content_missing_per_sha1: Type remaining existing endpoints
storage*: content_missing_per_sha1_git: Type remaining existing endpoints

Build is green

Patch application report for D3704 (id=13038)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..1a2aa70c
Fast-forward
 swh/storage/cassandra/storage.py | 52 ++++++++++++++---------
 swh/storage/in_memory.py         | 58 ++++++++++++++++---------
 swh/storage/interface.py         | 91 ++++++++++++++++++++++------------------
 swh/storage/storage.py           | 58 +++++++++++++++----------
 4 files changed, 156 insertions(+), 103 deletions(-)

Changes applied before test

commit 1a2aa70c687cbdac7655257ac3e6e572c8da43b4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:57:37 2020 +0200

    storage*: content_missing_per_sha1_git: Type remaining existing endpoints
    
    Related to T645

commit 15e48633a6a7beeccd233a38cdd456070fb4ae07
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:55:39 2020 +0200

    storage*: content_missing_per_sha1: Type remaining existing endpoints
    
    Related to T645

commit b62afbbbdd95aaa91163c8907fa7237231d7c3a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:13:43 2020 +0200

    storage*: content_missing: Unify and type remaining existing endpoints
    
    This updates the docstrings as well
    
    Related to T645

commit d6f26e45e9a62894ab2b888a15f8a4417c3b2ce0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:06:06 2020 +0200

    storage*: content_get_partition: Type remaining existing endpoints
    
    Related to T645

commit 864473370acdfd5acaf9afbfea9d16745b3c102f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:56:39 2020 +0200

    storage*: content_get_range: Type remaining existing endpoints
    
    Related to T645

commit c6da28289ec4f1be1eb1c1e78d561b8cc8dac937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 25ebc48198d665cc3bb71c96a8ae54775ddf38a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/675/ for more details.

Harbormaster completed remote builds in B14281: Diff 13038.Aug 4 2020, 9:47 PM

vlorentz accepted this revision.Aug 5 2020, 9:01 AM

This revision is now accepted and ready to land.Aug 5 2020, 9:01 AM

Closed by commit rDSTO15e48633a6a7: storage*: content_missing_per_sha1: Type remaining existing endpoints (authored by ardumont). · Explain WhyAug 5 2020, 11:54 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO15e48633a6a7: storage*: content_missing_per_sha1: Type remaining existing endpoints.

ardumont added a commit: rDSTO1a2aa70c687c: storage*: content_missing_per_sha1_git: Type remaining existing endpoints.

ardumont added a task: T2517: Add remaining missing types to swh.storage.interface.Aug 5 2020, 1:12 PM

ardumont removed a task: T645: Type swh-storage endpoints with swh.model objects.