Differential D3384

service/snapshot_count_branches: Improve empty snapshot detection
ClosedPublic
Actions

Authored by anlambert on Jun 30 2020, 5:37 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2429: web UI: empty repository reported as 404 snapshot not found

Commits

rDWAPPSc2726ac1249c: service/snapshot_count_branches: Improve empty snapshot detection

Summary

Handle the corner case of a snapshot containing branch or release aliases
pointing to dangling targets.

Closes T2429

Diff Detail

Repository

rDWAPPS Web applications

Branch

improve-empty-snapshot-detection

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13228
Build 20199: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20198: arc lint + arc unit

Event Timeline

anlambert created this revision.Jun 30 2020, 5:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 30 2020, 5:37 PM

anlambert edited the summary of this revision. (Show Details)Jun 30 2020, 5:41 PM

Fix typo in commit message

Build is green

Patch application report for D3384 (id=12008)

Rebasing onto 91f81bb1e4...

Current branch diff-target is up to date.

Changes applied before test

commit 3816846e6fc0ad2b232a68e8095df51ed7fdc474
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 30 17:02:18 2020 +0200

    service/snapshot_count_branches: Improve empty snapshot detection
    
    Handle the corner case of a snapshpot containing branch or release aliases
    pointing to dangling targets.
    
    Closes T2429

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/254/ for more details.

Harbormaster completed remote builds in B13227: Diff 12008.Jun 30 2020, 5:48 PM

Build is green

Patch application report for D3384 (id=12009)

Rebasing onto 91f81bb1e4...

Current branch diff-target is up to date.

Changes applied before test

commit e12a068dd344090a0357b087a6af9c18a45b0d28
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 30 17:02:18 2020 +0200

    service/snapshot_count_branches: Improve empty snapshot detection
    
    Handle the corner case of a snapshot containing branch or release aliases
    pointing to dangling targets.
    
    Closes T2429

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/255/ for more details.

Harbormaster completed remote builds in B13228: Diff 12009.Jun 30 2020, 5:58 PM

ardumont accepted this revision.Jul 1 2020, 9:36 AM

This revision is now accepted and ready to land.Jul 1 2020, 9:36 AM

Rebase

Build has FAILED

Patch application report for D3384 (id=12013)

Rebasing onto f433684afd...

Current branch diff-target is up to date.

Changes applied before test

commit c2726ac1249c57e5df6656eda6053c2bee7f809d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 30 17:02:18 2020 +0200

    service/snapshot_count_branches: Improve empty snapshot detection
    
    Handle the corner case of a snapshot containing branch or release aliases
    pointing to dangling targets.
    
    Closes T2429

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/258/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/258/console

Harbormaster failed remote builds in B13232: Diff 12013!Jul 1 2020, 11:10 AM

Build is green

Patch application report for D3384 (id=12013)

Rebasing onto f433684afd...

Current branch diff-target is up to date.

Changes applied before test

commit c2726ac1249c57e5df6656eda6053c2bee7f809d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 30 17:02:18 2020 +0200

    service/snapshot_count_branches: Improve empty snapshot detection
    
    Handle the corner case of a snapshot containing branch or release aliases
    pointing to dangling targets.
    
    Closes T2429

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/259/ for more details.

Harbormaster completed remote builds in B13232: Diff 12013.Jul 1 2020, 11:28 AM

Closed by commit rDWAPPSc2726ac1249c: service/snapshot_count_branches: Improve empty snapshot detection (authored by anlambert). · Explain WhyJul 1 2020, 11:31 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSc2726ac1249c: service/snapshot_count_branches: Improve empty snapshot detection.