Differential D3368

Migrate to Use the object's object_type field when computing objects
ClosedPublic
Actions

Authored by ardumont on Jun 29 2020, 11:47 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDBASE62aad2943238: Migrate to use object's "object_type" field when computing objects

Summary

Related to D3152

Related D3367

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 13174
Build 20110: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20109: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 29 2020, 11:47 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 29 2020, 11:47 AM

Build has FAILED

Patch application report for D3368 (id=11952)

Rebasing onto dc4946ad1a...

Current branch diff-target is up to date.

Changes applied before test

commit 374a200ade588fc199bc8c8b04af12e6081d0a4c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 29 11:46:56 2020 +0200

    Migrate to Use the object's object_type field when computing objects
    
    Related to D3152

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/87/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/87/console

Harbormaster failed remote builds in B13167: Diff 11952!Jun 29 2020, 11:47 AM

vlorentz accepted this revision.Jun 29 2020, 12:18 PM

This revision is now accepted and ready to land.Jun 29 2020, 12:18 PM

Rebase

Build has FAILED

Patch application report for D3368 (id=11957)

Rebasing onto dc4946ad1a...

Current branch diff-target is up to date.

Changes applied before test

commit 62aad2943238d2c1adfab91c2e4d32129a41eb75
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 29 11:46:56 2020 +0200

    Migrate to use object's "object_type" field when computing objects
    
    Related to D3152

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/88/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/88/console

Harbormaster failed remote builds in B13174: Diff 11957!Jun 29 2020, 4:10 PM

ardumont added a child revision: D3370: Use origin_add instead of deprecated origin_add_one endpoint.Jun 29 2020, 4:11 PM

ardumont edited the test plan for this revision. (Show Details)Jun 30 2020, 11:47 AM

Build is green

Patch application report for D3368 (id=11957)

Rebasing onto dc4946ad1a...

Current branch diff-target is up to date.

Changes applied before test

commit 62aad2943238d2c1adfab91c2e4d32129a41eb75
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 29 11:46:56 2020 +0200

    Migrate to use object's "object_type" field when computing objects
    
    Related to D3152

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/90/ for more details.

Harbormaster completed remote builds in B13174: Diff 11957.Jun 30 2020, 11:49 AM

Closed by commit rDLDBASE62aad2943238: Migrate to use object's "object_type" field when computing objects (authored by ardumont). · Explain WhyJun 30 2020, 11:51 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASE62aad2943238: Migrate to use object's "object_type" field when computing objects.

ardumont mentioned this in D3390: Unify object_type some more within the merkle and from_disk modules.Jul 2 2020, 11:17 AM

ardumont mentioned this in D3391: Refactor common loader behavior within swh.model.from_disk.iter_directory function.Jul 2 2020, 11:58 AM