Partially replaces D3247 (part 1/3)
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T2306: Generic storage for extrinsic, qualified metadata related to any node of the swh archive
- Commits
- rDSTO27e942621cef: Generalize origin_metadata to allow support for other object types in the…
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13163 Build 20091: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 20090: arc lint + arc unit
Event Timeline
Build is green
Patch application report for D3355 (id=11904)
Rebasing onto b991e69707...
First, rewinding head to replay your work on top of it... Applying: Generalize origin_metadata to allow support for other object types in the future.
Changes applied before test
commit 702cf25134d32b9e5010abc728401f02af01c08f Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Jun 25 17:42:31 2020 +0200 Generalize origin_metadata to allow support for other object types in the future.
See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/359/ for more details.
Nice!
Looks fine to me ;)
Got a couple of nits/remarks above.
Overall, i'm only missing edge case scenario (based on the coverage report).
sql/upgrades/156.sql | ||
---|---|---|
42 | storage deployment is gonna be fun... (replication wise ;) | |
swh/storage/cassandra/cql.py | ||
814 | i just realized we could do that heh ;) (build stuff within the decorator) | |
893 | types? | |
swh/storage/in_memory.py | ||
1006 | Remove the extra pass ;) | |
swh/storage/storage.py | ||
1164 | could you add a test for that part? | |
1224 | same here. |
swh/storage/in_memory.py | ||
---|---|---|
1006 | I'm blaming git |
swh/storage/in_memory.py | ||
---|---|---|
1006 | :D |
Build has FAILED
Patch application report for D3355 (id=11948)
Rebasing onto 10443b8a17...
First, rewinding head to replay your work on top of it... Applying: Generalize origin_metadata to allow support for other object types in the future.
Changes applied before test
commit d8fa4b9d5e75f4d12aa8338a5bc5b35450fe8bb1 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Jun 25 17:42:31 2020 +0200 Generalize origin_metadata to allow support for other object types in the future.
Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/381/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/381/console
Build is green
Patch application report for D3355 (id=11948)
Rebasing onto 10443b8a17...
First, rewinding head to replay your work on top of it... Applying: Generalize origin_metadata to allow support for other object types in the future.
Changes applied before test
commit 9d064fb0a018abbc7a774067377b46acfd81d251 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Jun 25 17:42:31 2020 +0200 Generalize origin_metadata to allow support for other object types in the future.
See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/384/ for more details.
swh/storage/sql/30-swh-schema.sql | ||
---|---|---|
443 | shouldn't there also be a description for the type column? What are the expected values for this? I guess it's an enum-kind of field right? |
swh/storage/sql/30-swh-schema.sql | ||
---|---|---|
443 | I added the list of values. Yes, it's like an enum, but I didn't use one because it doesn't match any of the enums we currently have (all DAG objects plus origins, but not visits) |
Build has FAILED
Patch application report for D3355 (id=11963)
Rebasing onto 10443b8a17...
Current branch diff-target is up to date.
Changes applied before test
commit 595d5462e14f010b6acae3e87ff6aa7ce75ae8ce Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Jun 25 17:42:31 2020 +0200 Generalize origin_metadata to allow support for other object types in the future.
Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/387/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/387/console
Build is green
Patch application report for D3355 (id=11980)
Rebasing onto 1f0e25615e...
Current branch diff-target is up to date.
Changes applied before test
commit 27e942621cef91cea6a98ffcc7beed5935714fe8 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Jun 25 17:42:31 2020 +0200 Generalize origin_metadata to allow support for other object types in the future.
See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/392/ for more details.