Differential D3366

templates/layout: Add origins search form in right part of top navbar
ClosedPublic
Actions

Authored by anlambert on Jun 26 2020, 6:45 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2319: Add search box in top bar

Commits

rDWAPPS1f756f7fa747: templates/layout: Add origins search form in right part of top navbar

Summary

Add a quick way to perform software origins search on every displayed page by
adding a search form in the top navbar.

Users will be redirected to search page when submitting it.

Remove the "Beta version" Ribbon as it was overlapping the search form.

Closes T2319

Diff Detail

Repository

rDWAPPS Web applications

Branch

navbar-search-form

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13160
Build 20086: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20085: arc lint + arc unit

Event Timeline

anlambert created this revision.Jun 26 2020, 6:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 26 2020, 6:45 PM

Build has FAILED

Patch application report for D3366 (id=11939)

Rebasing onto 04170796f4...

Current branch diff-target is up to date.

Changes applied before test

commit b95ced88ca4331f4069fa3de442032bffb5096d4
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 26 18:37:44 2020 +0200

    templates/layout: Add origins search form in right part of top navbar
    
    Add a quick way to perform software origins search on every displayed page by
    adding a search form in the top navbar.
    
    Users will be redirected to search page when submitting it.
    
    Remove the "Beta version" Ribbon as it was overlapping the search form.
    
    Closes T2319

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/234/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/234/console

Harbormaster failed remote builds in B13154: Diff 11939!Jun 26 2020, 6:55 PM

Nice ;)

This revision is now accepted and ready to land.Jun 29 2020, 10:39 AM

Update: Rebase and fix failing cypress test

Build is green

Patch application report for D3366 (id=11945)

Rebasing onto 7f8d2f0b2c...

Current branch diff-target is up to date.

Changes applied before test

commit 1f756f7fa747238fe40538ae552124b8da938780
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 26 18:37:44 2020 +0200

    templates/layout: Add origins search form in right part of top navbar
    
    Add a quick way to perform software origins search on every displayed page by
    adding a search form in the top navbar.
    
    Users will be redirected to search page when submitting it.
    
    Remove the "Beta version" Ribbon as it was overlapping the search form.
    
    Closes T2319

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/236/ for more details.

Harbormaster completed remote builds in B13160: Diff 11945.Jun 29 2020, 11:20 AM

Closed by commit rDWAPPS1f756f7fa747: templates/layout: Add origins search form in right part of top navbar (authored by anlambert). · Explain WhyJun 29 2020, 11:33 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS1f756f7fa747: templates/layout: Add origins search form in right part of top navbar.