Page MenuHomeSoftware Heritage

templates/vault-ui: Update links in downloads table
ClosedPublic

Authored by anlambert on Jun 24 2020, 12:21 PM.

Details

Summary

Add a link to browse the origin where a cooked object was found.

Update link to browse the cooked object: use SWHID with context URL.

Display cooked directory path if available.

Wrap some long lines in vault related Javascript code.

Below is a screenshot of the result:

Closes T2323

Diff Detail

Repository
rDWAPPS Web applications
Branch
vault-ui-update-links
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13078
Build 19944: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 19943: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3343 (id=11856)

Rebasing onto e8f3588ede...

Current branch diff-target is up to date.
Changes applied before test
commit 1f7b5f3ed3286f2f9150514b6302de0d9bccd39e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 24 11:40:58 2020 +0200

    templates/vault-ui: Update links in downloads table
    
    Add a link to browse the origin where a cooked object was found.
    
    Update link to browse the cooked object: use SWHID with context URL.
    
    Display cooked directory path if available.
    
    Wrap some long lines in vault related Javascript code.
    
    Closes T2323

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/217/ for more details.

Build is green

Patch application report for D3343 (id=11863)

Rebasing onto 25abbb1cfd...

Current branch diff-target is up to date.
Changes applied before test
commit 480f5a83415e3b83b3edb0090ebe863593b07a5c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 24 11:40:58 2020 +0200

    templates/vault-ui: Update links in downloads table
    
    Add a link to browse the origin where a cooked object was found.
    
    Update link to browse the cooked object: use SWHID with context URL.
    
    Display cooked directory path if available.
    
    Wrap some long lines in vault related Javascript code.
    
    Closes T2323

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/219/ for more details.

ardumont added a subscriber: ardumont.

Forgot to accept it.
Looks good ;)

This revision is now accepted and ready to land.Jun 24 2020, 4:32 PM