Page MenuHomeSoftware Heritage

assets: Migrate icons to Material Design Icons 5.3.45
ClosedPublic

Authored by anlambert on Jun 11 2020, 3:08 PM.

Details

Summary

Migrate swh-web icons (Font Awesome ones, octicon commit, png images) to their
Material Design Icons counterparts in order to get a consistent icons style (see
screenshots below).

Material Design Icons is an open source and exhaustive icons collection
allowing designers and developers targeting various platforms to download icons
in the format, color and size they need for any project.

Before:

After:

Closes T2445

Diff Detail

Repository
rDWAPPS Web applications
Branch
fontawesome-to-material-design
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12771
Build 19424: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 19423: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3261 (id=11566)

Rebasing onto 7bfa2333a4...

First, rewinding head to replay your work on top of it...
Applying: assets: Migrate icons to Material Design Icons 5.3.45
Changes applied before test
commit 549fc5ab8d3a65a1c13dca1da8730b0ceadddce8
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 10 15:11:33 2020 +0200

    assets: Migrate icons to Material Design Icons 5.3.45
    
    Migrate swh-web icons (Font Awesome ones, octicon commit, png images) to their
    Material Design Icons counterparts in order to get a consistent icons style.
    
    Material Design Icons is an open source and exhaustive icons collection
    allowing designers and developers targeting various platforms to download icons
    in the format, color and size they need for any project.
    
    Closes T2445

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/163/ for more details.

Build is green

Patch application report for D3261 (id=11567)

Rebasing onto 7bfa2333a4...

Current branch diff-target is up to date.
Changes applied before test
commit 586fdb481f624da4f55707624e508f90b6229e1a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 10 15:11:33 2020 +0200

    assets: Migrate icons to Material Design Icons 5.3.45
    
    Migrate swh-web icons (Font Awesome ones, octicon commit, png images) to their
    Material Design Icons counterparts in order to get a consistent icons style.
    
    Material Design Icons is an open source and exhaustive icons collection
    allowing designers and developers targeting various platforms to download icons
    in the format, color and size they need for any project.
    
    Closes T2445

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/164/ for more details.

Update: Tweak search button line-height for alignment

Build is green

Patch application report for D3261 (id=11570)

Rebasing onto 7bfa2333a4...

Current branch diff-target is up to date.
Changes applied before test
commit 992eaa81ab8070ca048d80fcc4f19f46ca9443ed
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 10 15:11:33 2020 +0200

    assets: Migrate icons to Material Design Icons 5.3.45
    
    Migrate swh-web icons (Font Awesome ones, octicon commit, png images) to their
    Material Design Icons counterparts in order to get a consistent icons style.
    
    Material Design Icons is an open source and exhaustive icons collection
    allowing designers and developers targeting various platforms to download icons
    in the format, color and size they need for any project.
    
    Closes T2445

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/165/ for more details.

ardumont added a subscriber: ardumont.

This looks nicer indeed.

Thanks.

I've got one question about a new origin-search form above.

swh/web/templates/includes/origin-search-form.html
35

Isn't this for another diff?

This revision is now accepted and ready to land.Jun 11 2020, 4:59 PM
swh/web/templates/includes/origin-search-form.html
35

Right ! I messed up while rebasing. Thanks for spotting this !

Update: Remove file added by mistake

Build is green

Patch application report for D3261 (id=11574)

Rebasing onto 7bfa2333a4...

Current branch diff-target is up to date.
Changes applied before test
commit 96a391f61230b7255f0332fc4d01de6a9296db2c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 11 18:00:23 2020 +0200

    assets: Migrate icons to Material Design Icons 5.3.45
    
    Migrate swh-web icons (Font Awesome ones, octicon commit, png images) to their
    Material Design Icons counterparts in order to get a consistent icons style.
    
    Material Design Icons is an open source and exhaustive icons collection
    allowing designers and developers targeting various platforms to download icons
    in the format, color and size they need for any project.
    
    Closes T2445

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/166/ for more details.

Update: Increase search icon size

Build is green

Patch application report for D3261 (id=11575)

Rebasing onto 7bfa2333a4...

Current branch diff-target is up to date.
Changes applied before test
commit de0dfcb3b561fa2970c104cc9fc44a9341f5df29
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jun 11 18:00:23 2020 +0200

    assets: Migrate icons to Material Design Icons 5.3.45
    
    Migrate swh-web icons (Font Awesome ones, octicon commit, png images) to their
    Material Design Icons counterparts in order to get a consistent icons style.
    
    Material Design Icons is an open source and exhaustive icons collection
    allowing designers and developers targeting various platforms to download icons
    in the format, color and size they need for any project.
    
    Closes T2445

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/167/ for more details.