Differential D3107

Added GiteaLister
ClosedPublic
Actions

Authored by legau on Apr 30 2020, 4:01 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLS1408517c089f: Added GiteaLister

Summary

Lister implementation for Gitea, works for (T2313). For now because of https://github.com/go-gitea/gitea/issues/9165 it would require setting its param limit to 50.

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12454
Build 18902: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 18901: arc lint + arc unit

Event Timeline

legau created this revision.Apr 30 2020, 4:01 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 30 2020, 4:01 PM

Build is green

Patch application report for D3107 (id=11051)

Rebasing onto 566294749e...

Current branch diff-target is up to date.

Changes applied before test

commit 9e15f49f35a7aaa8e38fff9730d8358974684b94
Author: Léni Gauffier <lenigauffier@gmail.com>
Date:   Thu Apr 30 15:56:19 2020 +0200

    Added GiteaLister

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/10/ for more details.

Harbormaster completed remote builds in B12222: Diff 11051.Apr 30 2020, 4:04 PM

Removed settings

Build is green

Patch application report for D3107 (id=11052)

Rebasing onto 566294749e...

Current branch diff-target is up to date.

Changes applied before test

commit ca831c779c39ac7bd4e5e94ce81ce370670745aa
Author: Léni Gauffier <lenigauffier@gmail.com>
Date:   Thu Apr 30 15:56:19 2020 +0200

    Added GiteaLister

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/11/ for more details.

Harbormaster completed remote builds in B12223: Diff 11052.Apr 30 2020, 4:08 PM

Hello,

Thanks for working on this \o/

I'm not familiar with gitea. I'll have a closer look though.
In the mean time, i've made some basic remark.

;)

Build is green

heh, btw, i think i had your issues (from the other lister diff) not so long
ago (working on another module, storage irrc)

It ended up being an issue when opening the diff without being able to push to
the "staging" repository for some (unknown yet) reason ¯\_(ツ)_/¯. jsyk heh ;)

swh/lister/gitea/tests/data/https_try.gitea.io/api_response.json
183	As before, can you please, reduce a bit the sample size (that will also decrease the apparent "huge" size of the diff, which can be quite intimidating at first ;) Thanks in advance
swh/lister/gitea/tests/data/https_try.gitea.io/api_v1_repos_search,page=1,sort=id,order=asc,limit=10
654 ↗	(On Diff #11052)	Same here please.

After a first look, nothing shocks me as wrong ;)
I will have another look later.

This looks quite promising, thanks again.

Reduced sample size

Build is green

Patch application report for D3107 (id=11266)

Rebasing onto 566294749e...

Current branch diff-target is up to date.

Changes applied before test

commit b292174b8cf16aab320391c909909fda356bfd55
Author: Léni Gauffier <lenigauffier@gmail.com>
Date:   Thu Apr 30 15:56:19 2020 +0200

    Added GiteaLister

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/12/ for more details.

Harbormaster completed remote builds in B12454: Diff 11266.May 20 2020, 1:33 PM

Well, looks fine to me.
I'm no gitea expert though so I'd like other team member to review as well.

Cheers,

This revision is now accepted and ready to land.May 27 2020, 6:05 PM

And thanks again for looking into it ;)

@legau You can push if you want ;)
(I can do it otherwise)

Cheers,

Will do,
Thanks

Closed by commit rDLS1408517c089f: Added GiteaLister (authored by legau). · Explain WhyJun 10 2020, 5:04 PM

This revision was automatically updated to reflect the committed changes.

legau added a commit: rDLS1408517c089f: Added GiteaLister.