but make it not click-specific (get rid of the ctx argument).
Details
Details
Diff Detail
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Branch
- pytest-plugin
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 11994 Build 18188: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 18187: arc lint + arc unit
Event Timeline
Comment Actions
Build was aborted
Patch application report for D3044 (id=10826)
Rebasing onto 42f4a89abc...
Current branch diff-target is up to date.
Changes applied before test
commit bec3b54f642016c9c7db97b7c34cc10a32ca49ac
Author: David Douard <david.douard@sdfa3.org>
Date: Wed Apr 22 16:31:31 2020 +0200
Move get_journal_client function in swh.journal.client
but make it not click-specific (get rid of the ctx argument).Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/53/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/53/console
Comment Actions
I'd say it'd be neat to add some docstrings and type at the same time, don't you think?
Comment Actions
Build is green
Patch application report for D3044 (id=10839)
Rebasing onto 42f4a89abc...
Current branch diff-target is up to date.
Changes applied before test
commit dc96335dbf5a245238b7fbedb7d81e36491c45c8
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Apr 23 11:00:09 2020 +0200
Normalize the get_journal_client() function
make it similar to other get_xxx factory functions we have:
- make it take a `cls` first argument (only supports "kafka" for now),
- take **kwargs as arguments to be passed to the class constructor.
This comes with the following changes in configuration:
- the config entry for the journal client is now "journal_client" (instead
of "journal"),
- the journal_client config dict must have a "cls" field (only "kafka" being
supported for now).
Compatibility should be ensured.
commit 72ea87ccf784f4a3f6e0d1def7abd371a8c77d5c
Author: David Douard <david.douard@sdfa3.org>
Date: Wed Apr 22 16:31:31 2020 +0200
Move get_journal_client function to swh.journal.client
but make it not click-specific (get rid of the ctx argument).
This is needed so we can use this function from non-cli related code,
and when extracting replayer out of swh-journal.See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/54/ for more details.