Differential D3016

storage.filter: Remove internal state from the filter
ClosedPublic
Actions

Authored by ardumont on Apr 14 2020, 10:55 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTOe5e594358b07: storage.filter: Remove internal state

Summary

This may not be needed. It sure lowers the state maintenance. So prefer
simplicity.

This also allows to abandon D3014 altogether.

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

simplify-filter-proxy

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11826
Build 17939: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 17938: arc lint + arc unit

Event Timeline

ardumont created this revision.Apr 14 2020, 10:55 AM

ardumont mentioned this in D3014: package.loader: Flush and clear regularly internal proxy storage states.Apr 14 2020, 10:57 AM

Build is green

Patch application report for D3016 (id=10707)

Rebasing onto ddac3d27e3...

Current branch diff-target is up to date.

Changes applied before test

commit e5e594358b078b4326b2af462fab0649676d5924
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Tue Apr 14 10:54:14 2020 +0200

    storage.filter: Remove internal state

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/93/ for more details.

Harbormaster completed remote builds in B11826: Diff 10707.Apr 14 2020, 11:01 AM

vlorentz accepted this revision.Apr 14 2020, 11:23 AM

This revision is now accepted and ready to land.Apr 14 2020, 11:23 AM

ardumont edited the summary of this revision. (Show Details)Apr 14 2020, 11:23 AM

Closed by commit rDSTOe5e594358b07: storage.filter: Remove internal state (authored by ardumont). · Explain WhyApr 14 2020, 11:28 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOe5e594358b07: storage.filter: Remove internal state.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

storage/

filter.py

32 lines

97%

tests/

test_filter.py

57 lines

100%

Diff 10707

View Options

swh/storage/filter.py