Page MenuHomeSoftware Heritage
Differential D2833

swh.web.settings.production: Fix mypy warning
ClosedPublic
Actions

Authored by ardumont on Mar 16 2020, 1:00 PM.

Details

Reviewers
anlambert
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS571dd0d1217e: swh.web.settings: Fix mypy issue
Summary

Fix ci [1]

Also the setup is correctly configured as per drf's doc [2]

[1] https://jenkins.softwareheritage.org/job/DWAPPS/job/tests/1182/console

[2] https://www.django-rest-framework.org/api-guide/settings/#num_proxies

Depends on D2830

Test Plan

tox -e mypy

Diff Detail

Event Timeline

ardumont created this revision.Mar 16 2020, 1:00 PM
ardumont edited the summary of this revision. (Show Details)Mar 16 2020, 1:02 PM
swh-public-ci added a comment.Mar 16 2020, 1:02 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1004/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1004/console

Harbormaster failed remote builds in B11135: Diff 10065!Mar 16 2020, 1:03 PM
ardumont added a comment.EditedMar 16 2020, 1:06 PM

Build has FAILED

lol, yeah, i tagged swh.storage v0.0.178
now it needs D2830 to work...

ardumont edited the summary of this revision. (Show Details)Mar 16 2020, 1:06 PM
ardumont added a parent revision: D2830: swh-web.tests: Migrate to latest swh-storage api change.
swh-public-ci added a comment.Mar 16 2020, 1:11 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1006/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1006/console

swh-public-ci added a comment.Mar 16 2020, 1:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/613/ for more details.

anlambert accepted this revision.Mar 16 2020, 1:13 PM
This revision is now accepted and ready to land.Mar 16 2020, 1:13 PM
swh-public-ci added a comment.Mar 16 2020, 1:22 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/615/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/615/console

swh-public-ci added a comment.Mar 16 2020, 1:34 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1008/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1008/console

swh-public-ci added a comment.Mar 16 2020, 1:39 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/617/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/617/console

swh-public-ci added a comment.Mar 16 2020, 1:50 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1010/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1010/console

swh-public-ci added a comment.Mar 16 2020, 1:54 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/619/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/619/console

swh-public-ci added a comment.Mar 16 2020, 2:00 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1011/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1011/console

anlambert added a comment.Mar 16 2020, 2:00 PM

I do not understand why the CI builds fail. Looks like parent diff is not applied but it should.

anlambert added a comment.Mar 16 2020, 2:02 PM

Oh I got it, the diff is not rebased on D2830

swh-public-ci added a comment.Mar 16 2020, 2:03 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/620/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/620/console

swh-public-ci added a comment.Mar 16 2020, 2:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1012/ for more details.

ardumont updated this revision to Diff 10070.Mar 16 2020, 2:17 PM

Rebase

ardumont added a comment.Mar 16 2020, 2:17 PM

Oh I got it, the diff is not rebased on D2830

oh yeah! oops. Thanks.

swh-public-ci added a comment.Mar 16 2020, 2:20 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1013/ for more details.

vlorentz requested changes to this revision.Mar 16 2020, 2:28 PM
vlorentz added a subscriber: vlorentz.

Why not set the type of REST_FRAMEWORK to Dict[str, Any] in common.py?

This revision now requires changes to proceed.Mar 16 2020, 2:28 PM
ardumont updated this revision to Diff 10072.Mar 16 2020, 2:42 PM

Fix the initial definition source as it's even more reasonable

ardumont added a comment.Mar 16 2020, 2:43 PM

Yes, better thanks.
I thought it was an original dict defined earlier in the django stanza internals.

Thanks.

ardumont retitled this revision from swh.web.settings.production: Ignore mypy warning to swh.web.settings.production: Fix mypy warning.Mar 16 2020, 2:43 PM
ardumont edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Mar 16 2020, 2:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1014/ for more details.

vlorentz accepted this revision.Mar 16 2020, 2:46 PM
This revision is now accepted and ready to land.Mar 16 2020, 2:46 PM
swh-public-ci added a comment.Mar 16 2020, 2:52 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/623/ for more details.

Harbormaster completed remote builds in B11141: Diff 10072.Mar 16 2020, 2:52 PM
Closed by commit rDWAPPS571dd0d1217e: swh.web.settings: Fix mypy issue (authored by ardumont). · Explain WhyMar 16 2020, 3:03 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDWAPPS571dd0d1217e: swh.web.settings: Fix mypy issue.

Revision Contents
Changeset List

PathSize
swh/
web/
settings/
6 lines

Diff 10072

View Options

swh/web/settings/common.py

Loading...
About · Developer information · Legal