Differential D6424 Diff 23343 swh/perfecthash/tests/test_hash.py

Changeset View

Standalone View

				from _hash_cffi import lib


				def test_build():
				assert lib.build(b"path") == 0
				ardumontUnsubmitted Done Inline Actions I don't get that comparison, where does the 5 ratio come from? ardumont: I don't get that comparison, where does the 5 ratio come from?
				ardumontUnsubmitted Done Inline Actions It seems to be a ratio that satisfies what's explained in the readme earlier (both for large and small files) but i still don't get where it comes from ;) ardumont: It seems to be a ratio that satisfies what's explained in the readme earlier (both for large…
				dacharyAuthorUnsubmitted Done Inline Actions The idea is to guard against massive performance regressions. When and if creating a shard is five times slower than copying a file... there is cause for concern. It comes from my head and has no real justification other than: this would be bad. dachary: The idea is to guard against massive performance regressions. When and if creating a shard is…
				ardumontUnsubmitted Done Inline Actions As a comment maybe something like: # According to the docs/benchmarks.rst analysis, the duration is below 5 times the baseline time # This assertion is here to ensure we do not not regress in the future... or something In any case, thanks for the explanation! ardumont: As a comment maybe something like: ``` # According to the docs/benchmarks.rst analysis, the…