Changeset View
Changeset View
Standalone View
Standalone View
swh/loader/git/tests/test_updater.py
- This file was added.
from swh.loader.git.updater import BulkUpdater | |||||
from swh.loader.git.tests.test_loader import ( | |||||
DirGitLoaderTest, LoaderNoStorageMixin) | |||||
class BulkUpdaterNoStorage(LoaderNoStorageMixin, BulkUpdater): | |||||
"""Subclass of BulkUpdater that uses a mock storage.""" | |||||
pass | |||||
class BulkUpdaterTest(DirGitLoaderTest): | |||||
ardumont: Same a docstring explaining what scenario is tested would be good. | |||||
Done Inline Actions(Ideally, we should have added that in the other test class as well but out of scope here, just mentioning it) ardumont: (Ideally, we should have added that in the other test class as well but out of scope here, just… | |||||
Not Done Inline ActionsThat's not helpful. There is no docstring in the DirGitLoaderTest class which explains anything. I know it's boring but it's useful. To have an example, check the loader-svn's tests [1] or the loader-mercurial's [2] ardumont: That's not helpful. There is no docstring in the DirGitLoaderTest class which explains anything. | |||||
"""Same tests as for the GitLoader, but running on BulkUpdater.""" | |||||
def setUp(self): | |||||
super().setUp() | |||||
self.loader = BulkUpdaterNoStorage() | |||||
def load(self): | |||||
return self.loader.load( | |||||
origin_url=self.repo_url) |
Same a docstring explaining what scenario is tested would be good.