Differential D5624 Diff 20117 assets/src/bundles/save/index.js

Changeset View

Standalone View

export function formatValuePerType(type, value) {

// Given some typed value, format and return accordingly formatted value

const mapFormatPerTypeFn = {

'json': (v) => JSON.stringify(v, null, 2),

'date': (v) => new Date(v).toLocaleString(),

'raw': (v) => v,

'duration': (v) => v + ' seconds'

};

return mapFormatPerTypeFn[type](value);

return value === null ? null : mapFormatPerTypeFn[type](value);

ardumontAuthorUnsubmitted

Done

'duration': (v) => v + ' seconds'

};

- return value !== null ? mapFormatPerTypeFn[type](value) : null;

+ return value === null ? null : mapFormatPerTypeFn[type](value);

}

export function displaySaveRequestInfo(event, saveRequestId) {

may be simpler to read (plus it avoids one negation we so love for some reason)

ardumont: may be simpler to read (plus it avoids one negation we so love for some reason)

}

export function displaySaveRequestInfo(event, saveRequestId) {

event.stopPropagation();

const saveRequestTaskInfoUrl = Urls.origin_save_task_info(saveRequestId);

// close popover when clicking again on the info icon

if ($(event.target).data('bs.popover')) {

$(event.target).popover('dispose');