Differential D5378 Diff 19271 swh/web/tests/common/test_origin_save.py

Changeset View

Standalone View

swh/web/tests/common/test_origin_save.py

	Show First 20 Lines • Show All 283 Lines • ▼ Show 20 Lines
	@pytest.mark.django_db			@pytest.mark.django_db
	def test_get_save_origin_requests_failed_when_not_found(mocker):			def test_get_save_origin_requests_failed_when_not_found(mocker):
	sors = _get_save_origin_requests(			sors = _get_save_origin_requests(
	mocker, load_status="uneventful", visit_status="not_found"			mocker, load_status="uneventful", visit_status="not_found"
	)			)
	assert len(sors) == 1			assert len(sors) == 1
	assert sors[0]["save_task_status"] == SAVE_TASK_FAILED			assert sors[0]["save_task_status"] == SAVE_TASK_FAILED
	assert sors[0]["visit_date"] is not None			assert sors[0]["visit_date"] is not None


				@pytest.mark.django_db
				def test_get_save_origin_requests_no_failed_status_override(mocker):
				sors = _get_save_origin_requests(
				mocker, load_status="uneventful", visit_status="not_found"
				)
				assert len(sors) == 1
				assert sors[0]["save_task_status"] == SAVE_TASK_FAILED
				assert sors[0]["visit_date"] is not None

				sors = get_save_origin_requests(_visit_type, _origin_url)
				ardumontUnsubmitted Not Done Inline Actions what was the value here prior to the fix? ardumont: what was the value here prior to the fix?
				anlambertAuthorUnsubmitted Done Inline Actions `SAVE_TASK_SUCCEEDED` ... The issue appeared since the exploitation of visit statuses (`not_found` for instance). Because it is costly to get the visit date and status associated to a request, that operation is performed once and status stored to django database. But prior getting a visit date, the overall save code now request status is retrieved from scheduler database (scheduled, running). So the final request status could be overridden. anlambert: `SAVE_TASK_SUCCEEDED` ... The issue appeared since the exploitation of visit statuses…
				ardumontUnsubmitted Not Done Inline Actions ok, thx ardumont: ok, thx
				assert sors[0]["save_task_status"] == SAVE_TASK_FAILED