Page MenuHomeSoftware Heritage
Differential D5118 Diff 18305 swh/model/tests/test_identifiers.py

Changeset View

Standalone View

View Options

swh/model/tests/test_identifiers.py

Show All 15 Lines
from swh.model.identifiers import ( from swh.model.identifiers import (
CONTENT, CONTENT,
DIRECTORY, DIRECTORY,
RELEASE, RELEASE,
REVISION, REVISION,
SNAPSHOT, SNAPSHOT,
SWHID, SWHID,
CoreSWHID, CoreSWHID,
ExtendedObjectType,
ExtendedSWHID,
ObjectType, ObjectType,
QualifiedSWHID, QualifiedSWHID,
normalize_timestamp, normalize_timestamp,
) )
def remove_id(d: Dict) -> Dict: def remove_id(d: Dict) -> Dict:
"""Returns a (shallow) copy of a dict with the 'id' key removed.""" """Returns a (shallow) copy of a dict with the 'id' key removed."""
▲ Show 20 Lines • Show All 1,240 Lines • ▼ Show 20 Lines@pytest.mark.parametrize(
[ [
"swh:1:cnt", "swh:1:cnt",
"swh:1:", "swh:1:",
"swh:", "swh:",
"swh:1:cnt:", "swh:1:cnt:",
"foo:1:cnt:abc8bc9d7a6bcf6db04f476d29314f157507d505", "foo:1:cnt:abc8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:2:dir:def8bc9d7a6bcf6db04f476d29314f157507d505", "swh:2:dir:def8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:1:foo:fed8bc9d7a6bcf6db04f476d29314f157507d505", "swh:1:foo:fed8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:1:ori:fed8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:1:emd:fed8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:1:dir:0b6959356d30f1a4e9b7f6bca59b9a336464c03d;invalid;malformed", "swh:1:dir:0b6959356d30f1a4e9b7f6bca59b9a336464c03d;invalid;malformed",
"swh:1:snp:gh6959356d30f1a4e9b7f6bca59b9a336464c03d", "swh:1:snp:gh6959356d30f1a4e9b7f6bca59b9a336464c03d",
"swh:1:snp:foo", "swh:1:snp:foo",
# wrong qualifier: ori should be origin # wrong qualifier: ori should be origin
"swh:1:dir:0b6959356d30f1a4e9b7f6bca59b9a336464c03d;ori=something;anchor=1;visit=1;path=/", # noqa "swh:1:dir:0b6959356d30f1a4e9b7f6bca59b9a336464c03d;ori=something;anchor=1;visit=1;path=/", # noqa
# wrong qualifier: anc should be anchor # wrong qualifier: anc should be anchor
"swh:1:dir:0b6959356d30f1a4e9b7f6bca59b9a336464c03d;origin=something;anc=1;visit=1;path=/", # noqa "swh:1:dir:0b6959356d30f1a4e9b7f6bca59b9a336464c03d;origin=something;anc=1;visit=1;path=/", # noqa
# wrong qualifier: vis should be visit # wrong qualifier: vis should be visit
▲ Show 20 Lines • Show All 151 Lines • ▼ Show 20 Lines@pytest.mark.parametrize(
[ [
"swh:1:cnt", "swh:1:cnt",
"swh:1:", "swh:1:",
"swh:", "swh:",
"swh:1:cnt:", "swh:1:cnt:",
"foo:1:cnt:abc8bc9d7a6bcf6db04f476d29314f157507d505", "foo:1:cnt:abc8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:2:dir:def8bc9d7a6bcf6db04f476d29314f157507d505", "swh:2:dir:def8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:1:foo:fed8bc9d7a6bcf6db04f476d29314f157507d505", "swh:1:foo:fed8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:1:ori:fed8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:1:emd:fed8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:1:dir:0b6959356d30f1a4e9b7f6bca59b9a336464c03d;visit=swh:1:snp:gh6959356d30f1a4e9b7f6bca59b9a336464c03d", # noqa "swh:1:dir:0b6959356d30f1a4e9b7f6bca59b9a336464c03d;visit=swh:1:snp:gh6959356d30f1a4e9b7f6bca59b9a336464c03d", # noqa
"swh:1:snp:gh6959356d30f1a4e9b7f6bca59b9a336464c03d", "swh:1:snp:gh6959356d30f1a4e9b7f6bca59b9a336464c03d",
"swh:1:snp:foo", "swh:1:snp:foo",
"swh:1: dir: 0b6959356d30f1a4e9b7f6bca59b9a336464c03d", "swh:1: dir: 0b6959356d30f1a4e9b7f6bca59b9a336464c03d",
], ],
) )
def test_parse_core_swhid_parsing_error(invalid_swhid): def test_parse_core_swhid_parsing_error(invalid_swhid):
with pytest.raises(ValidationError): with pytest.raises(ValidationError):
▲ Show 20 Lines • Show All 43 Lines • ▼ Show 20 Linesdef test_CoreSWHID_eq():
assert CoreSWHID( assert CoreSWHID(
object_type=ObjectType.DIRECTORY, object_id=object_id, object_type=ObjectType.DIRECTORY, object_id=object_id,
) == CoreSWHID(object_type=ObjectType.DIRECTORY, object_id=object_id,) ) == CoreSWHID(object_type=ObjectType.DIRECTORY, object_id=object_id,)
assert CoreSWHID( assert CoreSWHID(
object_type=ObjectType.DIRECTORY, object_id=object_id, object_type=ObjectType.DIRECTORY, object_id=object_id,
) == CoreSWHID(object_type=ObjectType.DIRECTORY, object_id=object_id,) ) == CoreSWHID(object_type=ObjectType.DIRECTORY, object_id=object_id,)
olasdUnsubmitted
Not Done
Inline Actions

This could probably be a pytest.mark.parametrized test instead of a for loop.

olasd: This could probably be a `pytest.mark.parametrize`d test instead of a for loop.
olasdUnsubmitted
Not Done
Inline Actions

Ah, I see you're doing that in D5121. Carry on.

olasd: Ah, I see you're doing that in D5121. Carry on.
def test_parse_serialize_extended_swhid():
for swhid, _type, _version, _hash in [
(
"swh:1:cnt:94a9ed024d3859793618152ea559a168bbcbb5e2",
ExtendedObjectType.CONTENT,
1,
_x("94a9ed024d3859793618152ea559a168bbcbb5e2"),
),
(
"swh:1:dir:d198bc9d7a6bcf6db04f476d29314f157507d505",
ExtendedObjectType.DIRECTORY,
1,
_x("d198bc9d7a6bcf6db04f476d29314f157507d505"),
),
(
"swh:1:rev:309cf2674ee7a0749978cf8265ab91a60aea0f7d",
ExtendedObjectType.REVISION,
1,
_x("309cf2674ee7a0749978cf8265ab91a60aea0f7d"),
),
(
"swh:1:rel:22ece559cc7cc2364edc5e5593d63ae8bd229f9f",
ExtendedObjectType.RELEASE,
1,
_x("22ece559cc7cc2364edc5e5593d63ae8bd229f9f"),
),
(
"swh:1:snp:c7c108084bc0bf3d81436bf980b46e98bd338453",
ExtendedObjectType.SNAPSHOT,
1,
_x("c7c108084bc0bf3d81436bf980b46e98bd338453"),
),
(
"swh:1:ori:c7c108084bc0bf3d81436bf980b46e98bd338453",
ExtendedObjectType.ORIGIN,
1,
_x("c7c108084bc0bf3d81436bf980b46e98bd338453"),
),
(
"swh:1:emd:c7c108084bc0bf3d81436bf980b46e98bd338453",
ExtendedObjectType.RAW_EXTRINSIC_METADATA,
1,
_x("c7c108084bc0bf3d81436bf980b46e98bd338453"),
),
]:
expected_result = ExtendedSWHID(
namespace="swh",
scheme_version=_version,
object_type=_type,
object_id=_hash,
)
actual_result = ExtendedSWHID.from_string(swhid)
assert actual_result == expected_result
assert str(expected_result) == str(actual_result) == swhid
@pytest.mark.parametrize(
"invalid_swhid",
[
"swh:1:cnt",
"swh:1:",
"swh:",
"swh:1:cnt:",
"foo:1:cnt:abc8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:2:dir:def8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:1:foo:fed8bc9d7a6bcf6db04f476d29314f157507d505",
"swh:1:dir:0b6959356d30f1a4e9b7f6bca59b9a336464c03d;visit=swh:1:snp:gh6959356d30f1a4e9b7f6bca59b9a336464c03d", # noqa
"swh:1:snp:gh6959356d30f1a4e9b7f6bca59b9a336464c03d",
"swh:1:snp:foo",
"swh:1: dir: 0b6959356d30f1a4e9b7f6bca59b9a336464c03d",
],
)
def test_parse_extended_swhid_parsing_error(invalid_swhid):
with pytest.raises(ValidationError):
ExtendedSWHID.from_string(invalid_swhid)
@pytest.mark.filterwarnings("ignore:.*SWHID.*:DeprecationWarning")
@pytest.mark.parametrize(
"ns,version,type,id",
[
(
"foo",
1,
ExtendedObjectType.CONTENT,
"abc8bc9d7a6bcf6db04f476d29314f157507d505",
),
(
"swh",
2,
ExtendedObjectType.CONTENT,
"def8bc9d7a6bcf6db04f476d29314f157507d505",
),
("swh", 1, ExtendedObjectType.DIRECTORY, "aaaa"),
],
)
def test_ExtendedSWHID_validation_error(ns, version, type, id):
with pytest.raises(ValidationError):
ExtendedSWHID(
namespace=ns, scheme_version=version, object_type=type, object_id=_x(id),
)
def test_ExtendedSWHID_hash():
object_id = _x("94a9ed024d3859793618152ea559a168bbcbb5e2")
assert hash(
ExtendedSWHID(object_type=ExtendedObjectType.DIRECTORY, object_id=object_id)
) == hash(
ExtendedSWHID(object_type=ExtendedObjectType.DIRECTORY, object_id=object_id)
)
assert hash(
ExtendedSWHID(object_type=ExtendedObjectType.DIRECTORY, object_id=object_id,)
) == hash(
ExtendedSWHID(object_type=ExtendedObjectType.DIRECTORY, object_id=object_id,)
)
# Different order of the dictionary, so the underlying order of the tuple in
# ImmutableDict is different.
assert hash(
ExtendedSWHID(object_type=ExtendedObjectType.DIRECTORY, object_id=object_id,)
) == hash(
ExtendedSWHID(object_type=ExtendedObjectType.DIRECTORY, object_id=object_id,)
)
def test_ExtendedSWHID_eq():
object_id = _x("94a9ed024d3859793618152ea559a168bbcbb5e2")
assert ExtendedSWHID(
object_type=ExtendedObjectType.DIRECTORY, object_id=object_id
) == ExtendedSWHID(object_type=ExtendedObjectType.DIRECTORY, object_id=object_id)
assert ExtendedSWHID(
object_type=ExtendedObjectType.DIRECTORY, object_id=object_id,
) == ExtendedSWHID(object_type=ExtendedObjectType.DIRECTORY, object_id=object_id,)
assert ExtendedSWHID(
object_type=ExtendedObjectType.DIRECTORY, object_id=object_id,
) == ExtendedSWHID(object_type=ExtendedObjectType.DIRECTORY, object_id=object_id,)
About · Developer information · Legal