Differential D4867 Diff 17237 swh/lister/pypi/tests/test_tasks.py

Changeset View

Standalone View

swh/lister/pypi/tests/test_tasks.py

	# Copyright (C) 2019-2020 The Software Heritage developers			# Copyright (C) 2019-2020 The Software Heritage developers
	# See the AUTHORS file at the top-level directory of this distribution			# See the AUTHORS file at the top-level directory of this distribution
	# License: GNU General Public License version 3, or any later version			# License: GNU General Public License version 3, or any later version
	# See top-level LICENSE file for more information			# See top-level LICENSE file for more information

	from unittest.mock import patch			from unittest.mock import patch

				from swh.lister.pattern import ListerStats


	def test_ping(swh_scheduler_celery_app, swh_scheduler_celery_worker):			def test_ping(swh_scheduler_celery_app, swh_scheduler_celery_worker):
	res = swh_scheduler_celery_app.send_task("swh.lister.pypi.tasks.ping")			res = swh_scheduler_celery_app.send_task("swh.lister.pypi.tasks.ping")
	assert res			assert res
	res.wait()			res.wait()
	assert res.successful()			assert res.successful()
	assert res.result == "OK"			assert res.result == "OK"


	@patch("swh.lister.pypi.tasks.PyPILister")			@patch("swh.lister.pypi.tasks.PyPILister")
	def test_lister(lister, swh_scheduler_celery_app, swh_scheduler_celery_worker):			def test_lister(lister, swh_scheduler_celery_app, swh_scheduler_celery_worker):
	# setup the mocked PypiLister			# setup the mocked PypiLister
	lister.return_value = lister			lister.return_value = lister
	lister.run.return_value = None			lister.run.return_value = ListerStats(pages=1, origins=70)

	res = swh_scheduler_celery_app.send_task("swh.lister.pypi.tasks.PyPIListerTask")			res = swh_scheduler_celery_app.send_task("swh.lister.pypi.tasks.PyPIListerTask")
	assert res			assert res
	res.wait()			res.wait()
	assert res.successful()			assert res.successful()

	lister.assert_called_once_with()			lister.assert_called_once_with()
	lister.db_last_index.assert_not_called()
	lister.run.assert_called_once_with()			lister.run.assert_called_once_with()
				anlambertUnsubmitted Done Inline Actions Use `assert_called_once` instead. anlambert: Use `assert_called_once` instead.
				olasdUnsubmitted Done Inline Actions `assert_called_once()` doesn't check what arguments have been used, which `assert_called_once_with()` does, so I think using it is fine? olasd: `assert_called_once()` doesn't check what arguments have been used, which…
				anlambertUnsubmitted Done Inline Actions Right, I should have proofread `unittest` doc, invalid comment here. anlambert: Right, I should have proofread `unittest` doc, invalid comment here.