Differential D4713 Diff 16698 swh/deposit/tests/api/test_checks.py

Changeset View

Standalone View

swh/deposit/tests/api/test_checks.py

Show All 17 Lines	[
"atom:author": "someone",		"atom:author": "someone",
},		},
{		{
"atom:url": "some url",		"atom:url": "some url",
"atom:external_identifier": "some id",		"atom:external_identifier": "some id",
"atom:title": "bar",		"atom:title": "bar",
"atom:author": "no one",		"atom:author": "no one",
},		},
		{"atom:url": "some url", "codemeta:name": "bar", "codemeta:author": "no one",},
],		],
)		)
def test_api_checks_check_metadata_ok(metadata_ok, swh_checks_deposit):		def test_api_checks_check_metadata_ok(metadata_ok, swh_checks_deposit):
actual_check, detail = check_metadata(metadata_ok)		actual_check, detail = check_metadata(metadata_ok)
assert actual_check is True		assert actual_check is True, detail
assert detail is None		assert detail is None


@pytest.mark.parametrize(		@pytest.mark.parametrize(
"metadata_ko,expected_summary",		"metadata_ko,expected_summary",
[		[
(		(
{		{
"atom:url": "something",		"atom:url": "something",
"atom:external_identifier": "something-else",		"atom:external_identifier": "something-else",
"atom:author": "someone",		"atom:author": "someone",
},		},
{		{
"summary": "Mandatory alternate fields are missing",		"summary": "Mandatory fields are missing",
"fields": ["atom:name or atom:title"],		"fields": ["atom:name or atom:title or codemeta:name"],
},		},
),		),
(		(
{		{
"atom:url": "something",		"atom:url": "something",
"atom:external_identifier": "something-else",		"atom:external_identifier": "something-else",
"atom:title": "foobar",		"atom:title": "foobar",
},		},
{"summary": "Mandatory fields are missing", "fields": ["atom:author"],},		{
		"summary": "Mandatory fields are missing",
		"fields": ["atom:author or codemeta:author"],
		},
		),
		(
		{
		"atom:url": "something",
		"atom:external_identifier": "something-else",
		"codemeta:title": "bar",
		"atom:author": "someone",
		},
		{
		"summary": "Mandatory fields are missing",
		"fields": ["atom:name or atom:title or codemeta:name"],
		},
		),
		(
		{
		"atom:url": "something",
		"atom:external_identifier": "something-else",
		"atom:title": "foobar",
		"author": "foo",
		},
		{
		"summary": "Mandatory fields are missing",
		"fields": ["atom:author or codemeta:author"],
		},
),		),
],		],
)		)
def test_api_checks_check_metadata_ko(		def test_api_checks_check_metadata_ko(
metadata_ko, expected_summary, swh_checks_deposit		metadata_ko, expected_summary, swh_checks_deposit
):		):
"""Missing optional field should be caught		"""Missing optional field should be caught

"""		"""
actual_check, error_detail = check_metadata(metadata_ko)		actual_check, error_detail = check_metadata(metadata_ko)
assert actual_check is False		assert actual_check is False
assert error_detail == {"metadata": [expected_summary]}		assert error_detail == {"metadata": [expected_summary]}