Changeset View
Changeset View
Standalone View
Standalone View
swh/loader/mercurial/__init__.py
| # Copyright (C) 2019 The Software Heritage developers | # Copyright (C) 2019 The Software Heritage developers | ||||
| # See the AUTHORS file at the top-level directory of this distribution | # See the AUTHORS file at the top-level directory of this distribution | ||||
| # License: GNU General Public License version 3, or any later version | # License: GNU General Public License version 3, or any later version | ||||
| # See top-level LICENSE file for more information | # See top-level LICENSE file for more information | ||||
| from typing import Any, Mapping | from typing import Any, Mapping | ||||
| def register() -> Mapping[str, Any]: | def register() -> Mapping[str, Any]: | ||||
| """Register the current worker module's definition""" | """Register the current worker module's definition""" | ||||
| from .loader import HgBundle20Loader | from .loader import HgBundle20Loader | ||||
| return { | return { | ||||
| "task_modules": [f"{__name__}.tasks"], | "task_modules": [f"{__name__}.tasks"], | ||||
| "loader": HgBundle20Loader, | "loader": HgBundle20Loader, | ||||
| } | } | ||||
| def register_from_disk() -> Mapping[str, Any]: | |||||
| """Register the current worker module's definition""" | |||||
| from .from_disk import HgLoaderFromDisk | |||||
| return { | |||||
| "task_modules": [f"{__name__}.tasks_from_disk"], | |||||
| "loader": HgLoaderFromDisk, | |||||
| } | |||||
marmoute: Does this means we are using the new loader instead of the previous on as soon as this diff… | |||||
Done Inline ActionsThe switch will be done in loader.py acezar: The switch will be done in `loader.py` | |||||
Done Inline ActionsYes it will, and clearly we do not want this behavior. Typically, we want to be able to select the implementation to use in a given context. This register function is normally called from the swh.workers entrypoint, so it would be best to have a dedicated entrypoint for this new implementation. douardda: Yes it will, and clearly we do not want this behavior. Typically, we want to be able to select… | |||||
Done Inline Actionswill add a loader.mercurial_from_disk=swh.loader.mercurial:register_from_disk. Thanks for the hint. acezar: will add a `loader.mercurial_from_disk=swh.loader.mercurial:register_from_disk`. Thanks for the… | |||||
Does this means we are using the new loader instead of the previous on as soon as this diff land ? Should we move this to a different diff so that we can enable it later when the new loader have been fully validated ?