Differential D4052 Diff 14284 swh/deposit/tests/api/test_deposit_update.py

Changeset View

Standalone View

swh/deposit/tests/api/test_deposit_update.py

# Copyright (C) 2017-2020 The Software Heritage developers		# Copyright (C) 2017-2020 The Software Heritage developers
# See the AUTHORS file at the top-level directory of this distribution		# See the AUTHORS file at the top-level directory of this distribution
# License: GNU General Public License version 3, or any later version		# License: GNU General Public License version 3, or any later version
# See top-level LICENSE file for more information		# See top-level LICENSE file for more information

from io import BytesIO		from io import BytesIO

from django.core.files.uploadedfile import InMemoryUploadedFile		from django.core.files.uploadedfile import InMemoryUploadedFile
from django.urls import reverse		from django.urls import reverse
from rest_framework import status		from rest_framework import status

from swh.deposit.config import EDIT_SE_IRI, EM_IRI		from swh.deposit.config import (
		DEPOSIT_STATUS_DEPOSITED,
		DEPOSIT_STATUS_PARTIAL,
		EDIT_SE_IRI,
		EM_IRI,
		)
from swh.deposit.models import Deposit, DepositCollection, DepositRequest		from swh.deposit.models import Deposit, DepositCollection, DepositRequest
from swh.deposit.parsers import parse_xml		from swh.deposit.parsers import parse_xml
from swh.deposit.tests.common import check_archive, create_arborescence_archive		from swh.deposit.tests.common import check_archive, create_arborescence_archive
from swh.model.hashutil import hash_to_bytes		from swh.model.hashutil import hash_to_bytes
from swh.model.identifiers import parse_swhid, swhid		from swh.model.identifiers import parse_swhid, swhid


def test_replace_archive_to_deposit_is_possible(		def test_replace_archive_to_deposit_is_possible(
▲ Show 20 Lines • Show All 559 Lines • ▼ Show 20 Lines	):
assert requests[0].raw_metadata == expected_raw_meta0		assert requests[0].raw_metadata == expected_raw_meta0
assert requests[1].raw_metadata == data_atom_entry		assert requests[1].raw_metadata == data_atom_entry

# check we did not touch the other parts		# check we did not touch the other parts
requests_archive1 = DepositRequest.objects.filter(deposit=deposit, type="archive")		requests_archive1 = DepositRequest.objects.filter(deposit=deposit, type="archive")
assert len(requests_archive1) == 1 + 1, "New deposit request metadata got added"		assert len(requests_archive1) == 1 + 1, "New deposit request metadata got added"


		def test_post_metadata_empty_post_finalize_deposit_ok(
		authenticated_client,
		deposit_collection,
		partial_deposit_with_metadata,
		atom_dataset,
		):
		"""Empty atom post entry with header in-progress to false can actually finish a deposit
		moraneggUnsubmitted Not Done Inline Actions I actually don't get which scenario is tested. Let's see: empty atom is the xml -> no xml file? it's a POST (so not an update, so for now it can't be just metadata). header is `in-progress` Clarify in docstring moranegg: I actually don't get which scenario is tested. Let's see: empty atom is the xml -> no xml file?
		ardumontAuthorUnsubmitted Done Inline Actions I'm testing the conditional in the `deposit_update.py` code above (which is orange in another diff, that means untested [1] You can check that the blue near the scrollbar which says 'alright, we passed there now` (when the build is actually finished being run that is :) [1] not covered in the previous diffs i opened, which adds coverage to some other uncovered part (which ... same players plays again ...). I'm playing whackamole with our current deposit_update module here ¯\_(ツ)_/¯ ardumont: I'm testing the conditional in the `deposit_update.py` code above (which is orange in another…

		Response: 200
		"""
		deposit = partial_deposit_with_metadata
		assert deposit.status == DEPOSIT_STATUS_PARTIAL

		moraneggUnsubmitted Not Done Inline Actions checking that the deposit is still in-progress moranegg: checking that the deposit is still in-progress
		ardumontAuthorUnsubmitted Done Inline Actions yes, but the assert is enough to say as much. ardumont: yes, but the assert is enough to say as much.
		requests = DepositRequest.objects.filter(deposit=deposit, type="metadata")
		assert len(requests) == 1
		requests_archive0 = DepositRequest.objects.filter(deposit=deposit, type="archive")
		assert len(requests_archive0) == 1

		update_uri = reverse(EDIT_SE_IRI, args=[deposit_collection.name, deposit.id])
		response = authenticated_client.post(
		update_uri,
		content_type="application/atom+xml;type=entry",
		data="",
		size=0,
		HTTP_IN_PROGRESS=False,
		)
		moraneggUnsubmitted Not Done Inline Actions here it's `deposited`. So there was an update for a `partial` deposit with only metadata. right? moranegg: here it's `deposited`. So there was an update for a `partial` deposit with only metadata. right?
		ardumontAuthorUnsubmitted Done Inline Actions It did not do anything but transitions the status from partial to deposited (the deposit already has the necessary archive and metadata). ardumont: It did not do anything but transitions the status from partial to deposited (the deposit…

		assert response.status_code == status.HTTP_200_OK

		deposit = Deposit.objects.get(pk=deposit.id)
		assert deposit.status == DEPOSIT_STATUS_DEPOSITED


def test_add_metadata_to_unknown_deposit(		def test_add_metadata_to_unknown_deposit(
deposit_collection, authenticated_client, atom_dataset		deposit_collection, authenticated_client, atom_dataset
):		):
"""Replacing metadata to unknown deposit should return a 404 response		"""Replacing metadata to unknown deposit should return a 404 response

"""		"""
unknown_deposit_id = 1000		unknown_deposit_id = 1000
try:		try:
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines