Differential D3735 Diff 13160 swh/loader/package/npm/tests/test_npm.py

Changeset View

Standalone View

Show First 20 Lines • Show All 366 Lines • ▼ Show 20 Lines	assert {
"origin_visit": 1,		"origin_visit": 1,
"person": 2,		"person": 2,
"release": 0,		"release": 0,
"revision": len(_expected_new_revisions_first_visit),		"revision": len(_expected_new_revisions_first_visit),
"skipped_content": 0,		"skipped_content": 0,
"snapshot": 1,		"snapshot": 1,
} == stats		} == stats

contents_d = loader.storage.content_get_metadata(_expected_new_contents_first_visit)		contents = loader.storage.content_get(_expected_new_contents_first_visit)
		vlorentzUnsubmitted Not Done Inline Actions I don't like negative in conditionals with an else block, could you use `0 if content is None else 1`? vlorentz: I don't like negative in conditionals with an else block, could you use `0 if content is None…
		ardumontAuthorUnsubmitted Done Inline Actions yeah, better. thanks. ardumont: yeah, better. thanks.
count = sum(1 if len(contents) > 0 else 0 for contents in contents_d.values())		count = sum(0 if content is None else 1 for content in contents)
assert count == len(_expected_new_contents_first_visit)		assert count == len(_expected_new_contents_first_visit)

assert (		assert (
list(loader.storage.directory_missing(_expected_new_directories_first_visit))		list(loader.storage.directory_missing(_expected_new_directories_first_visit))
== []		== []
)		)

assert (		assert (
▲ Show 20 Lines • Show All 324 Lines • Show Last 20 Lines