Differential D3473 Diff 12316 swh/loader/tests/__init__.py

Changeset View

Standalone View

swh/loader/tests/init.py

# Copyright (C) 2018-2020 The Software Heritage developers		# Copyright (C) 2018-2020 The Software Heritage developers
# See the AUTHORS file at the top-level directory of this distribution		# See the AUTHORS file at the top-level directory of this distribution
# License: GNU General Public License version 3, or any later version		# License: GNU General Public License version 3, or any later version
# See top-level LICENSE file for more information		# See top-level LICENSE file for more information

import os		import os
import subprocess		import subprocess

from pathlib import PosixPath		from pathlib import PosixPath
from typing import Dict, Optional, Union		from typing import Any, Dict, Optional, Union

from swh.model.model import OriginVisitStatus		from swh.model.model import OriginVisitStatus, Snapshot
from swh.model.hashutil import hash_to_bytes, hash_to_hex		from swh.model.hashutil import hash_to_bytes, hash_to_hex

		from swh.storage.interface import StorageInterface
from swh.storage.algos.origin import origin_get_latest_visit_status		from swh.storage.algos.origin import origin_get_latest_visit_status


def assert_last_visit_matches(		def assert_last_visit_matches(
storage,		storage,
url: str,		url: str,
status: str,		status: str,
type: Optional[str] = None,		type: Optional[str] = None,
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines	) -> str:
# uncompress folder/repositories/dump for the loader to ingest		# uncompress folder/repositories/dump for the loader to ingest
subprocess.check_output(["tar", "xf", archive_path, "-C", tmp_path])		subprocess.check_output(["tar", "xf", archive_path, "-C", tmp_path])
# build the origin url (or some derivative form)		# build the origin url (or some derivative form)
_fname = filename if filename else os.path.basename(archive_path)		_fname = filename if filename else os.path.basename(archive_path)
repo_url = f"file://{tmp_path}/{_fname}"		repo_url = f"file://{tmp_path}/{_fname}"
return repo_url		return repo_url


def decode_target(target):		def decode_target(target: Dict) -> Dict:
"""Test helper to ease readability in test		"""Test helper to ease readability in test

"""		"""
if not target:		if not target:
return target		return target
target_type = target["target_type"]		target_type = target["target_type"]
		target_data = target["target"]
if target_type == "alias":		if target_type == "alias" and isinstance(target_data, bytes):
decoded_target = target["target"].decode("utf-8")		decoded_target = target_data.decode("utf-8")
		elif isinstance(target_data, bytes):
		decoded_target = hash_to_hex(target_data)
else:		else:
decoded_target = hash_to_hex(target["target"])		decoded_target = target_data

return {"target": decoded_target, "target_type": target_type}		return {"target": decoded_target, "target_type": target_type}


def check_snapshot(expected_snapshot, storage):		def check_snapshot(
		snapshot: Union[Dict[str, Any], Snapshot], storage: StorageInterface
		):
"""Check for snapshot match.		"""Check for snapshot match.

Provide the hashes as hexadecimal, the conversion is done		The hashes can be both in hex or bytes, the necessary conversion will happen prior
within the method.		to check.

Args:		Args:
expected_snapshot (dict): full snapshot with hex ids		expected_snapshot: full snapshot to check for existence and consistency
		douarddaUnsubmitted Not Done Inline Actions expected_snapshot or snapshot ? douardda: expected_snapshot or snapshot ?
		ardumontAuthorUnsubmitted Done Inline Actions It's the `expected_snapshot` but i renamed it so it can reuse the name internally without mypy annoying me with its type. I forgot to rename the docstring, i'll fix that. ardumont: It's the `expected_snapshot` but i renamed it so it can reuse the name internally without mypy…
storage (Storage): expected storage		storage: storage to lookup information into

Returns:		Returns:
the snapshot stored in the storage for further test assertion if any is		the snapshot stored in the storage for further test assertion if any is
needed.		needed.

"""		"""
		if isinstance(snapshot, Snapshot):
		ardumontAuthorUnsubmitted Done Inline Actions oh i wanted to avoid the isinstance call initially but i recall i can't in the end (mypy)... need to simplify this. ardumont: oh i wanted to avoid the isinstance call initially but i recall i can't in the end (mypy)...
		expected_snapshot = snapshot.to_dict()
		douarddaUnsubmitted Not Done Inline Actions Since we try to go full "model object everywhere", why not use the Snapshot within this test rather than the dict form? douardda: Since we try to go full "model object everywhere", why not use the Snapshot within this test…
		ardumontAuthorUnsubmitted Done Inline Actions Because I went with the existing code which already manipulated the dict. (also i try to keep diff small somehow, i gather modifying more would have meant more code) ardumont: Because I went with the existing code which already manipulated the dict. (also i try to keep…
		ardumontAuthorUnsubmitted Done Inline Actions And it means more code, for example, i'd need to code the symmetric `encode_target` here so i can `Snapshot.from_dict` the all thing. ardumont: And it means more code, for example, i'd need to code the symmetric `encode_target` here so i…
		ardumontAuthorUnsubmitted Done Inline Actions And then convert the snapshot dict returned from the storage endpoint... (which i think started it all). ardumont: And then convert the snapshot dict returned from the storage endpoint... (which i think started…
		ardumontAuthorUnsubmitted Done Inline Actions context: trying to do as you proposed. Even though unfinished, i found the result quite unreadable in terms of error message... I'm not sure i want to do that... ardumont: context: trying to do as you proposed. Even though unfinished, i found the result quite…
		elif isinstance(snapshot, dict):
		expected_snapshot = snapshot
		else:
		anlambertUnsubmitted Not Done Inline Actions I think you want a f-string here right ? anlambert: I think you want a f-string here right ?
		ardumontAuthorUnsubmitted Done Inline Actions yeah (damn!) ardumont: yeah (damn!)
		raise AssertionError(f"variable 'snapshot' must be a snapshot: {snapshot!r}")
		douarddaUnsubmitted Not Done Inline Actions I think this is unnecessary (the `else` case). This is testing code, if something incorrect is given, it will fail anyway. douardda: I think this is unnecessary (the `else` case). This is testing code, if something incorrect is…
		ardumontAuthorUnsubmitted Done Inline Actions might as well be explicit? I'm annoyed when i don't understand immediately the assertion failure (and it happens). ardumont: might as well be explicit? I'm annoyed when i don't understand immediately the assertion…

expected_snapshot_id = expected_snapshot["id"]		expected_snapshot_id = expected_snapshot["id"]
expected_branches = expected_snapshot["branches"]		expected_branches = expected_snapshot["branches"]
snap = storage.snapshot_get(hash_to_bytes(expected_snapshot_id))		snap = storage.snapshot_get(hash_to_bytes(expected_snapshot_id))
if snap is None:		if snap is None:
raise AssertionError(f"Snapshot {expected_snapshot_id} is not found")		raise AssertionError(f"Snapshot {expected_snapshot_id} is not found")

branches = {		expected_branches = {}
branch.decode("utf-8"): decode_target(target)		for branch, target in expected_snapshot["branches"].items():
for branch, target in snap["branches"].items()		if isinstance(branch, bytes):
}		branch = branch.decode("utf-8")
assert expected_branches == branches		expected_branches[branch] = decode_target(target)

		snapshot_branches = {}
		for branch, target in snap["branches"].items():
		anlambertUnsubmitted Not Done Inline Actions branch type is always bytes no ? anlambert: branch type is always bytes no ?
		ardumontAuthorUnsubmitted Done Inline Actions not necessarily in test. Initially, to simplify the test writing, we allowed to pass dict-like model object with hashes as hex. And let that function do the work to convert appropriately for the comparison to actually work. ardumont: not necessarily in test. Initially, to simplify the test writing, we allowed to pass dict-like…
		if isinstance(branch, bytes):
		branch = branch.decode("utf-8")
		snapshot_branches[branch] = decode_target(target)
		ardumontAuthorUnsubmitted Done Inline Actions Inverted the order to match what we do in other loaders. Unsure if it's a good idea though. ardumont: Inverted the order to match what we do in other loaders. Unsure if it's a good idea though.
		ardumontAuthorUnsubmitted Done Inline Actions I reverted it. ardumont: I reverted it.
		assert expected_branches == snapshot_branches
return snap		return snap


def get_stats(storage) -> Dict:		def get_stats(storage) -> Dict:
"""Adaptation utils to unify the stats counters across storage		"""Adaptation utils to unify the stats counters across storage
implementation.		implementation.

"""		"""
Show All 15 Lines